Bug 174981

Summary:

[JSC] Support optional catch binding

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

JavaScriptCore

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, keith_miller, mark.lam, msaboff, rniwa, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews102 for mac-elcapitan	none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2	none
Patch	none
Patch	none
Patch	saam: review+, buildbot: commit-queue-
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none

Yusuke Suzuki

Reported 2017-07-31 04:43:18 PDT

https://michaelficarra.github.io/optional-catch-binding-proposal/ ``` try { ... } catch { ... } ```

Attachments
Patch (9.82 KB, patch) 2017-07-31 05:03 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-elcapitan (1.23 MB, application/zip) 2017-07-31 05:57 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (1.47 MB, application/zip) 2017-07-31 06:03 PDT, Build Bot	no flags	Details
Patch (12.93 KB, patch) 2017-07-31 06:09 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (13.29 KB, patch) 2017-07-31 06:14 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (14.85 KB, patch) 2017-07-31 06:34 PDT, Yusuke Suzuki	saam: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.29 MB, application/zip) 2017-07-31 07:38 PDT, Build Bot	no flags	Details
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Yusuke Suzuki

Comment 1 2017-07-31 04:44:24 PDT

Now, it's stage 3.

Yusuke Suzuki

Comment 2 2017-07-31 05:03:14 PDT

Created attachment 316766 [details] Patch

Yusuke Suzuki

Comment 3 2017-07-31 05:56:41 PDT

Test rebaseline is necessary...

Build Bot

Comment 4 2017-07-31 05:57:46 PDT

Comment on attachment 316766 [details] Patch Attachment 316766 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4228810 New failing tests: js/parser-syntax-check.html sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T4.html

Build Bot

Comment 5 2017-07-31 05:57:47 PDT

Created attachment 316768 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 6 2017-07-31 06:03:26 PDT

Comment on attachment 316766 [details] Patch Attachment 316766 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4228817 New failing tests: js/parser-syntax-check.html sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T4.html

Build Bot

Comment 7 2017-07-31 06:03:27 PDT

Created attachment 316769 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Yusuke Suzuki

Comment 8 2017-07-31 06:09:51 PDT

Created attachment 316770 [details] Patch

Yusuke Suzuki

Comment 9 2017-07-31 06:14:11 PDT

Created attachment 316771 [details] Patch

Yusuke Suzuki

Comment 10 2017-07-31 06:34:44 PDT

Created attachment 316773 [details] Patch

Build Bot

Comment 11 2017-07-31 07:38:28 PDT

Comment on attachment 316773 [details] Patch Attachment 316773 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4229208 New failing tests: fast/images/link-body-content-imageDimensionChanged-crash.html

Build Bot

Comment 12 2017-07-31 07:38:29 PDT

Created attachment 316778 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Saam Barati

Comment 13 2017-07-31 09:08:29 PDT

Comment on attachment 316773 [details] Patch r=me

Yusuke Suzuki

Comment 14 2017-07-31 09:15:43 PDT

Committed r220068: <http://trac.webkit.org/changeset/220068>

Radar WebKit Bug Importer

Comment 15 2017-07-31 09:16:35 PDT

<rdar://problem/33626279>

Note You need to log in before you can comment on or make changes to this bug.