Summary: | [GTK] Building with ENABLE_VIDEO=OFF fails | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adrian Perez <aperez> | ||||
Component: | WebKitGTK | Assignee: | Adrian Perez <aperez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, aestes, bburg, beidson, bugs-noreply, cgarcia, commit-queue | ||||
Priority: | P2 | ||||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Adrian Perez
2017-07-28 09:39:32 PDT
I looked a bit into this, and it's caused because MEDIA_STREAM is enabled anyway, and it tries to use the definition of HTMLVideoElement, which is guarded by ENABLE(VIDEO). This is due to a missing feature dependency in the CMake build files. We need to add: WEBKIT_OPTION_DEPEND(ENABLE_MEDIA_STREAM ENABLE_VIDEO) I'll be submitting a patch. A test build with of “trunk” with “-DENABLE_MEDIA_STREAM=OFF” failed with: ../../Tools/TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:25:10: fatal error: gst/gst.h: No such file or directory #include <gst/gst.h> ^~~~~~~~~~~ If all of “-DENABLE_VIDEO=OFF”, “-DENABLE_WEB_AUDIO=OFF” and “-DENABLE_MEDIA_STREAM=OFF” is passed, then GStreamer is not needed, and no GStreamer flags are queried using “pkg-config”. Which results in the header not found. I think in this case we would want to guard the use of GStreamer in the tests as well, so I'll add that to the patch. Created attachment 316646 [details]
Patch
Comment on attachment 316646 [details] Patch Clearing flags on attachment: 316646 Committed r220007: <http://trac.webkit.org/changeset/220007> All reviewed patches have been landed. Closing bug. |