Summary: | Using "auto <function()> -> returnType" breaks prepare-ChangeLog | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | JF Bastien <jfbastien> | ||||||
Component: | Tools / Tests | Assignee: | JF Bastien <jfbastien> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | beidson, buildbot, commit-queue, dbates, jbedard, jfbastien, lforschler, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
JF Bastien
2017-07-27 23:33:38 PDT
Created attachment 316624 [details]
patch
Pardon my perl.
We have unit tests for this code. Please add a unit test to <https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp> and update the expected result in <https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt>. You can run the unit tests using the script Tools/Scripts/test-webkitperl. Created attachment 316644 [details] patch (In reply to Daniel Bates from comment #2) > We have unit tests for this code. Please add a unit test to "unit tests"? What are those? ;-) While I'm here, I also added const and volatile overloads. Attachment 316644 [details] did not pass style-queue:
ERROR: Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:396: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:420: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:425: This { should be at the end of the previous line [whitespace/braces] [4]
Total errors found: 3 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 316644 [details] patch Clearing flags on attachment: 316644 Committed r220010: <http://trac.webkit.org/changeset/220010> All reviewed patches have been landed. Closing bug. Committed r220017: <http://trac.webkit.org/changeset/220017> |