Bug 174884 – Add ability to only run specific tests in run-javascriptcore-tests.

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Mark Lam]

For example, if we only want to run testapi, we can do so as follows:
    $ run-javascriptcore-tests --testapi

Previously, specifying --testapi effectively does nothing because we run all tests by default.  Only --no-testapi had the effect of disabling the test set.  This old behavior for --testapi is not very useful or meaningful.  We're now changing it to mean that we will only run that test.

With this change, we can also run more than one set of tests.  For example, if only want to run testmasm and testair, we can do so as follows:
    $ run-javascriptcore-tests --testmasm --testair

By default, if no specific test option is specified, run-javascript-core will run all tests.

Note that the jsc stress tests (--jsc-stress) are a different set of tests than the mozilla tests (-mozilla-tests).  Hence, if you only specify one of them, the other set will not run.  For example, the following only runs the mozilla tests:
    $ run-javascriptcore-tests --mozilla-tests

Note also that --jit-stress-tests is not for choosing a different set of tests.  Instead, it is used for determining whether we run the jit test configuration subset of the jsc stress test and mozilla tests.  As a result, specifying --jit-stress-tests will not omit other tests.  For example, the following still runs all tests:
    $ run-javascriptcore-tests --jit-stress-tests

[Mark Lam]

Created attachment 316522 [details]
proposed patch.

[Saam Barati]

Comment on attachment 316522 [details]
proposed patch.

r=me
Seems reasonable

[Build Bot]

Comment on attachment 316522 [details]
proposed patch.

Attachment 316522 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4194645

New failing tests:
imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html

[Build Bot]

Created attachment 316526 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Mark Lam]

(In reply to Build Bot from comment #3)
> New failing tests:
> imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html

Again, this test failure is bogus because this patch does not touch anything that can possibly affect the failing test.

[Mark Lam]

Thanks for the review.  Landed in r219984: <http://trac.webkit.org/r219984>.

[Joseph Pecoraro]

Awesome this is much saner!