Dashboard: JavaScript exception when expected elements are not present in Buildbot data

• Component: Tools / Tests
• Status: ASSIGNED ---

[Aakash Jain]

Dashboard code can hit exceptions while trying to access the elements which are not present in the data. We should check if the elements are present before parsing the data from them. This condition is hit particularly while using buildbot 0.9.

[Aakash Jain]

Created attachment 316471 [details]
Proposed patch

[Daniel Bates]

Comment on attachment 316471 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316471&action=review

Can we write a unit test for this change?

> Tools/ChangeLog:3
> +        Dashboard: Don't crash when expected elements are not present in buildbot data

"Crash" is not the correct terminology to use to refer to a JavaScript exception or error.

> Tools/ChangeLog:9
> +        (BuildbotIteration.prototype.failureLogURL): check if _firstFailedStep.logs is present before accessing

Please capitalize the first letter in this sentence.

> Tools/ChangeLog:11
> +        (BuildbotIteration.prototype._parseData): check if data.sourceStamps is present before accessing its length.

Ditto.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:247
> +        else if (data.sourceStamps)

Is it possible for the version of Buildbot we use in OpenSource or internally to not have both sourceStamp and sourceStamps defined. If not, then I suggest we defer making this change until we upgrade OpenSource to the latest version. I know that the latest Buildbot does not have this property from talking with you today.