Summary: | Web Inspector: Don't output "No message" for multi-value logs like console.log(x, y) | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||
Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, inspector-bugzilla-changes, joepeck, mattbaker | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Joseph Pecoraro
2017-07-25 16:15:03 PDT
Created attachment 316404 [details]
[PATCH] Proposed Fix
Created attachment 316405 [details]
[PATCH] Proposed Fix
Now that commit-queue has caught up to the rest of the world.
Comment on attachment 316405 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=316405&action=review r=me > Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js:476 > + } I know it's only in two places, but a helper might be nice: function createDivider() { let divider = document.createElement("span"); divider.textContent = ` ${enDash} `; divider.classList.add("console-message-preview-divider"); return divider; } if (needsDivider) { builderElement.appendChild(createDivider()); Comment on attachment 316405 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=316405&action=review >> Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js:476 >> + } > > I know it's only in two places, but a helper might be nice: > > function createDivider() { > let divider = document.createElement("span"); > divider.textContent = ` ${enDash} `; > divider.classList.add("console-message-preview-divider"); > return divider; > } > > if (needsDivider) { > builderElement.appendChild(createDivider()); This actually exposed an issue, in the case below `enclosedElement` is used later on to add the "inline-lossless" class if it is needed. I extracted this out into an: `appendDividerIfNeeded` method which then makes it easy to correct the code below as well. Created attachment 316417 [details]
[PATCH] For Landing
Comment on attachment 316417 [details] [PATCH] For Landing Clearing flags on attachment: 316417 Committed r219900: <http://trac.webkit.org/changeset/219900> |