Bug 174828

Summary: Use SandboxExtension::HandleArray when sending extensions for file uploads to the web process
Product: WebKit Reporter: BJ Burg <bburg>
Component: WebKit2Assignee: BJ Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, darin, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 174867    
Bug Blocks:    
Attachments:
Description Flags
Proposed Fix
none
Followup fix none

Description BJ Burg 2017-07-25 12:28:29 PDT 
Minor code cleanup.

I didn't merge this into the didChooseFilesForOpenPanel message, since the necessity of sandbox extensions depends on ENABLE(SANDBOX_EXTENSIONS). I don't want to conditionally define the same message more than one way since we don't do that anywhere else that I'm aware of.
Comment 1 BJ Burg 2017-07-25 12:30:25 PDT 
Created attachment 316383 [details]
Proposed Fix
Comment 2 WebKit Commit Bot 2017-07-25 14:22:32 PDT 
Comment on attachment 316383 [details]
Proposed Fix

Clearing flags on attachment: 316383

Committed r219887: <http://trac.webkit.org/changeset/219887>
Comment 3 WebKit Commit Bot 2017-07-25 14:22:34 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Darin Adler 2017-07-25 18:00:04 PDT 
Comment on attachment 316383 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=316383&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:3841
> +    for (size_t i = 0; i < handles.size(); ++i) {

I would prefer a modern for loop here. Presuming that there is a begin/end function on HandleArray.
Comment 5 WebKit Commit Bot 2017-07-26 10:47:03 PDT 
Re-opened since this is blocked by bug 174867
Comment 6 BJ Burg 2017-07-26 10:54:26 PDT 
Created attachment 316455 [details]
Followup fix
Comment 7 Tim Horton 2017-07-26 10:54:56 PDT 
Comment on attachment 316455 [details]
Followup fix

Heh. Better.
Comment 8 WebKit Commit Bot 2017-07-26 11:32:49 PDT 
Comment on attachment 316455 [details]
Followup fix

Clearing flags on attachment: 316455

Committed r219952: <http://trac.webkit.org/changeset/219952>
Comment 9 WebKit Commit Bot 2017-07-26 11:32:50 PDT 
All reviewed patches have been landed.  Closing bug.