Bug 174828

Summary: Use SandboxExtension::HandleArray when sending extensions for file uploads to the web process
Product: WebKit Reporter: Blaze Burg <bburg>
Component: WebKit2Assignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, darin, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 174867    
Bug Blocks:    
Attachments:
Description Flags
Proposed Fix
none
Followup fix none

Blaze Burg
Reported 2017-07-25 12:28:29 PDT
Minor code cleanup. I didn't merge this into the didChooseFilesForOpenPanel message, since the necessity of sandbox extensions depends on ENABLE(SANDBOX_EXTENSIONS). I don't want to conditionally define the same message more than one way since we don't do that anywhere else that I'm aware of.
Attachments
Proposed Fix (6.76 KB, patch)
2017-07-25 12:30 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Followup fix (3.61 KB, patch)
2017-07-26 10:54 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2017-07-25 12:30:25 PDT
Created attachment 316383 [details] Proposed Fix
WebKit Commit Bot
Comment 2 2017-07-25 14:22:32 PDT
Comment on attachment 316383 [details] Proposed Fix Clearing flags on attachment: 316383 Committed r219887: <http://trac.webkit.org/changeset/219887>
WebKit Commit Bot
Comment 3 2017-07-25 14:22:34 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 4 2017-07-25 18:00:04 PDT
Comment on attachment 316383 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=316383&action=review > Source/WebKit/WebProcess/WebPage/WebPage.cpp:3841 > + for (size_t i = 0; i < handles.size(); ++i) { I would prefer a modern for loop here. Presuming that there is a begin/end function on HandleArray.
WebKit Commit Bot
Comment 5 2017-07-26 10:47:03 PDT
Re-opened since this is blocked by bug 174867
Blaze Burg
Comment 6 2017-07-26 10:54:26 PDT
Created attachment 316455 [details] Followup fix
Tim Horton
Comment 7 2017-07-26 10:54:56 PDT
Comment on attachment 316455 [details] Followup fix Heh. Better.
WebKit Commit Bot
Comment 8 2017-07-26 11:32:49 PDT
Comment on attachment 316455 [details] Followup fix Clearing flags on attachment: 316455 Committed r219952: <http://trac.webkit.org/changeset/219952>
WebKit Commit Bot
Comment 9 2017-07-26 11:32:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.