Bug 17481

Summary: Several consecutive calls to XMLHttpRequest::open should dispatch only one readyState event
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: XMLAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: ap
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch + test case
ap: review+
patch updated with Ap's comments darin: review+

Julien Chaffraix
Reported 2008-02-21 16:00:28 PST
Even thought not mentioned in the spec, IE, Firefox and Opera does show this behaviour. Patch + test case will follow.
Attachments
patch + test case (4.29 KB, patch)
2008-02-21 16:36 PST, Julien Chaffraix 		ap: review+
DetailsFormatted DiffDiff
patch updated with Ap's comments (3.41 KB, patch)
2008-02-23 06:02 PST, Julien Chaffraix 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2008-02-21 16:36:13 PST
Created attachment 19266 [details] patch + test case Add readyState check in open : if the readyState is not open then raise a readyState event
Alexey Proskuryakov
Comment 2 2008-02-21 23:40:33 PST
Comment on attachment 19266 [details] patch + test case r=me, with comments. + int previousState = m_state; The type of this variable should be XMLHttpRequestState. + // Check previous state to avoid dispatching readyState event + // when calling several times open in a row Looks like it should be "calling open several times in a row". Also, it's better to put a period at the end of the sentence.
Julien Chaffraix
Comment 3 2008-02-23 06:02:04 PST
Created attachment 19295 [details] patch updated with Ap's comments > The type of this variable should be XMLHttpRequestState. changed. > Looks like it should be "calling open several times in a row". Also, it's > better to put a period at the end of the sentence. Changed words' order and added a period. I also updated the test case so that the result is more human readable.
Darin Adler
Comment 4 2008-02-23 09:29:53 PST
Comment on attachment 19295 [details] patch updated with Ap's comments r=ap (no need for him to review again)
Alexey Proskuryakov
Comment 5 2008-02-27 09:48:07 PST
Committed revision 30626 (but I had to write a ChangeLog).
Alexey Proskuryakov
Comment 6 2011-11-10 11:18:47 PST
Bug 71985 asks to undo this.
Note You need to log in before you can comment on or make changes to this bug.