Bug 174802

Summary: [WK2][Cocoa] Allow overriding the ITP data removal internal using a default
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, bfulgham, commit-queue, ggaren, jbedard, sam, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2017-07-24 16:03:43 PDT 
Allow overriding the ITP data removal internal using a default to facilitate testing.
Comment 1 Chris Dumez 2017-07-24 16:03:57 PDT 
<rdar://problem/33497898>
Comment 2 Chris Dumez 2017-07-24 16:10:46 PDT 
Created attachment 316327 [details]
Patch
Comment 3 Sam Weinig 2017-07-24 16:24:04 PDT 
Comment on attachment 316327 [details]
Patch

If this is for debugging, this should be in the FOR_EACH_WEBKIT_DEBUG_BOOL_PREFERENCE list. In general, I am confused about the use of WebPreferencesKey with NSUserDefaults.  That is how what these keys are for.
Comment 4 Chris Dumez 2017-07-24 16:25:10 PDT 
(In reply to Sam Weinig from comment #3)
> Comment on attachment 316327 [details]
> Patch
> 
> If this is for debugging, this should be in the
> FOR_EACH_WEBKIT_DEBUG_BOOL_PREFERENCE list. In general, I am confused about
> the use of WebPreferencesKey with NSUserDefaults.  That is how what these
> keys are for.

Oh. I merely followed what the existing ITP defaults did. I'll take a look at moving all of them then.
Comment 5 Chris Dumez 2017-07-24 17:00:10 PDT 
Created attachment 316329 [details]
Patch
Comment 6 WebKit Commit Bot 2017-07-24 20:07:30 PDT 
Comment on attachment 316329 [details]
Patch

Clearing flags on attachment: 316329

Committed r219855: <http://trac.webkit.org/changeset/219855>
Comment 7 WebKit Commit Bot 2017-07-24 20:07:31 PDT 
All reviewed patches have been landed.  Closing bug.