Bug 174798 – Web Inspector: Add three.js in preparation for layer visualization.

• Component: Web Inspector
• Status: RESOLVED FIXED

[Ross Kirsling]

Add three.js and its OrbitControls as a prerequisite for the 3D layer visualization.

[Ross Kirsling]

Created attachment 316332 [details]
Patch

[Alexey Proskuryakov]

three.js appears to be under MIT license, which is not one of those allowed in WebKit. I don't know exactly how this works, but we may need some extra review of license terms.

[Alexey Proskuryakov]

Comment on attachment 316332 [details]
Patch

R- since this patch violates license requirements set on patch upload page, and there is no indication that there was an exception agreed upon.

[Ross Kirsling]

Sure. Brian mentioned on IRC that "if you want to check in three.js and orbit controls, I can start a request with our legal team", so I'd opened this ticket accordingly.

[Ross Kirsling]

Note that among the existing libraries in Web Inspector, CodeMirror and ESLint are both MIT-licensed, while Esprima is BSD-licensed (which should be equivalent: https://choosealicense.com/appendix/).

I'm surprised that a conversation should even be necessary regarding permissive OSS licenses, but presumably this should just be a matter of doing. :)

[Alexey Proskuryakov]

> I'm surprised that a conversation should even be necessary regarding permissive OSS licenses 

Seems worth raising this on webkit-dev mailing list.

[Blaze Burg]

Comment on attachment 316332 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316332&action=review

Please upload a new patch with directory rename.

When you actually hook this into the build system, you'll need to make sure it gets minified properly. That should be in a follow up patch separate from the source dump.

> Source/WebInspectorUI/ChangeLog:8
> +        * UserInterface/External/Three/LICENSE: Added.

Can you put it into directory named three.js or threejs instead of Three?

> Source/WebInspectorUI/UserInterface/Main.html:246
> +    <script src="External/Three/OrbitControls.js"></script>

No need to include it until it's used.

[Ross Kirsling]

Created attachment 317855 [details]
Patch

[Blaze Burg]

Comment on attachment 317855 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 317855 [details]
Patch

Rejecting attachment 317855 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 317855, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
fs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 220563 = 79a999cbe204abbc99b3ba8e1b8a1d659720d01e
r220565 = dedd274b9feaeb9e589fbcfde9b3958152a25309
r220566 = 104789904f418c99cf355973ee0f95a4f017490e
r220567 = 0a63ca5d8ceb2abd6d17e2abfab369ecf4c3b0b5
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/4292876

[Ross Kirsling]

Looks like we'll need to sanitize those damn tabs after all. *shakes fist*

[Ross Kirsling]

Created attachment 317901 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 317901 [details]
Patch

Clearing flags on attachment: 317901

Committed r220575: <http://trac.webkit.org/changeset/220575>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/33842044>