Bug 174785

Summary:

[CMake] libtasn1 should not be required when not enabling subtle_crypto

Product:

WebKit

Reporter:

Carlos Alberto Lopez Perez <clopez>

Component:

WPE WebKit

Assignee:

Carlos Alberto Lopez Perez <clopez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bugs-noreply, jiewen_tan, mmaxfield, zan

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Carlos Alberto Lopez Perez 2017-07-24 08:20:59 PDT

After r218626 <https://trac.webkit.org/r218626> libtasn1 is required for building WebKitGTK or WPE even when not enabling subtle_crypto.


In file included from /home/clopez/webkit/Source/WebCore/PAL/pal/crypto/tasn1/Utilities.cpp:28:0:
/home/clopez/webkit/Source/WebCore/PAL/pal/crypto/tasn1/Utilities.h:29:22: fatal error: libtasn1.h: No such file or directory
 #include <libtasn1.h>
                      ^
compilation terminated.
Source/WebCore/PAL/pal/CMakeFiles/PAL.dir/build.make:89: recipe for target 'Source/WebCore/PAL/pal/CMakeFiles/PAL.dir/crypto/tasn1/Utilities.cpp.o' failed
make[2]: *** [Source/WebCore/PAL/pal/CMakeFiles/PAL.dir/crypto/tasn1/Utilities.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....


The only source files including pal/crypto/tasn1/Utilities.h are CryptoKeyECGCrypt.cpp and CryptoKeyRSAGCrypt.cpp which are only included if ENABLE_SUBTLE_CRYPTO=ON

Comment 1 Carlos Alberto Lopez Perez 2017-07-24 08:24:45 PDT

Created attachment 316290 [details]
Patch

Comment 2 Carlos Alberto Lopez Perez 2017-07-24 09:01:39 PDT

Comment on attachment 316290 [details]
Patch

Clearing flags on attachment: 316290

Committed r219823: <http://trac.webkit.org/changeset/219823>

Comment 3 Carlos Alberto Lopez Perez 2017-07-24 09:01:43 PDT

All reviewed patches have been landed.  Closing bug.