Summary: | Handle case where line_numbers is None instead of an array of line numbers | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Manuel Rego Casasnovas <rego> | ||||||||
Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | aakash_jain, buildbot, commit-queue, ddkilzer, glenn, jbedard, lforschler | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 173559 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Manuel Rego Casasnovas
2017-07-24 00:37:42 PDT
Created attachment 316291 [details]
Patch
A bit surprised we didn't have a unit test for this. It's a simple fix, added a test as well. Comment on attachment 316291 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316291&action=review > Tools/Scripts/webkitpy/style/filereader.py:115 > + if 'line_numbers' in kwargs and kwargs['line_numbers']: Please check if we can simplify this to if kwargs.get('line_numbers'): > Tools/Scripts/webkitpy/style/main_unittest.py:165 > + def test_linter_added_file(self): Nit: should this name be more descriptive? Created attachment 316299 [details]
Patch
Created attachment 316300 [details]
Patch for landing
Comment on attachment 316300 [details] Patch for landing Clearing flags on attachment: 316300 Committed r219827: <http://trac.webkit.org/changeset/219827> All reviewed patches have been landed. Closing bug. |