Bug 174767

Summary:

[GTK] A typo in the reference manual of WebKitWebInspector

Product:

WebKit

Reporter:

Takuro Ashie <ashie>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

berto, bugs-noreply, buildbot, cgarcia, commit-queue, gustavo, mcatanzaro

Priority:

Keywords:

Gtk

Version:

WebKit Nightly Build

Hardware:

OS:

Linux

Attachments:

Description	Flags
Patch	none

Takuro Ashie

Reported 2017-07-23 19:23:37 PDT

There is a typo in an example code in the reference manual of WebKitWebInspector. https://webkitgtk.org/reference/webkit2gtk/stable/WebKitWebInspector.html https://trac.webkit.org/browser/webkit/trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebInspector.cpp?rev=218332#L53 - webkit_web_load_uri (WEBKIT_WEB_VIEW(my_webview), "http://www.gnome.org"); + webkit_web_view_load_uri (WEBKIT_WEB_VIEW(my_webview), "http://www.gnome.org"); "view" is missing in the function name.

Attachments
Patch (1.54 KB, patch) 2017-07-23 19:39 PDT, Takuro Ashie	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Takuro Ashie

Comment 1 2017-07-23 19:39:28 PDT

Build Bot

Comment 2 2017-07-23 19:41:53 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Michael Catanzaro

Comment 3 2017-07-23 19:42:24 PDT

Comment on attachment 316252 [details] Patch Thank you for submitting this fix! I'm impressed you noticed.

WebKit Commit Bot

Comment 4 2017-07-23 20:20:32 PDT

WebKit Commit Bot

Comment 5 2017-07-23 20:20:34 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.