Bug 174711

Summary: [WPE] Add libepoxy to the Jhbuild moduleset
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 174780    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Zan Dobersek
Reported 2017-07-21 07:39:02 PDT
[WPE] Add libepoxy to the Jhbuild moduleset
Attachments
Patch (4.62 KB, patch)
2017-07-21 07:53 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2017-07-21 07:53:59 PDT
Created attachment 316087 [details] Patch
Zan Dobersek
Comment 2 2017-07-24 02:41:22 PDT
This will need some more work -- libepoxy 1.4.1 uses generated EGL definitions that use EGL_CAST() macros, as defined at the bottom of eglplatform.h: https://www.khronos.org/registry/EGL/api/EGL/eglplatform.h Not all distributions keep this header up-to-date, for instance in Mesa EGL_CAST was only added in 17.1. Proposed solution is to include epoxy headers through an intermediate header that also defines EGL_CAST in case the platform-provided eglplatform.h header doesn't define that already.
Zan Dobersek
Comment 3 2017-07-24 07:26:46 PDT
(In reply to Zan Dobersek from comment #2) > This will need some more work -- libepoxy 1.4.1 uses generated EGL > definitions that use EGL_CAST() macros, as defined at the bottom of > eglplatform.h: > https://www.khronos.org/registry/EGL/api/EGL/eglplatform.h > Fixed in bug #174780.
Zan Dobersek
Comment 4 2017-07-24 07:27:54 PDT
Comment on attachment 316087 [details] Patch Clearing flags on attachment: 316087 Committed r219820: <http://trac.webkit.org/changeset/219820>
Zan Dobersek
Comment 5 2017-07-24 07:27:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.