Bug 174691 – Hook up ITP quirks to the needsSiteSpecificQuirks setting

• Component: WebKit2
• Status: RESOLVED FIXED

[Chris Dumez]

Hook up ITP quirks to the needsSiteSpecificQuirks setting.

[Chris Dumez]

Created attachment 316030 [details]
Patch

[Chris Dumez]

Created attachment 316036 [details]
Patch

[Jeremy Jones]

Comment on attachment 316036 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316036&action=review

provisional r+

> Source/WebCore/ChangeLog:8
> +        Hook up ITP quirks to the needsSiteSpecificQuirks setting to make it easier to

nit: easier for

[Chris Dumez]

Created attachment 316043 [details]
Patch

[Darin Adler]

Comment on attachment 316043 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316043&action=review

> Source/WebCore/loader/ResourceLoadObserver.cpp:65
> +#if PLATFORM(IOS)
> +    UNUSED_PARAM(page);
> +
> +    // There is currently no way to toggle the needsSiteSpecificQuirks setting on iOS so we always enable
> +    // the site-specific quirks on iOS.
> +    return true;
> +#else

It is really strange that this logic is here rather than in Settings.

[Chris Dumez]

(In reply to Darin Adler from comment #5)
> Comment on attachment 316043 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=316043&action=review
> 
> > Source/WebCore/loader/ResourceLoadObserver.cpp:65
> > +#if PLATFORM(IOS)
> > +    UNUSED_PARAM(page);
> > +
> > +    // There is currently no way to toggle the needsSiteSpecificQuirks setting on iOS so we always enable
> > +    // the site-specific quirks on iOS.
> > +    return true;
> > +#else
> 
> It is really strange that this logic is here rather than in Settings.

The setting is disabled on iOS. However, I need the ITP quirk on iOS as well. We could enable the setting on iOS but then it would enable other quirks than ITP on iOS, which would be risky at this point.

[WebKit Commit Bot]

Comment on attachment 316043 [details]
Patch

Clearing flags on attachment: 316043

Committed r219711: <http://trac.webkit.org/changeset/219711>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 316043 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316043&action=review

>>> Source/WebCore/loader/ResourceLoadObserver.cpp:65
>>> +#else
>> 
>> It is really strange that this logic is here rather than in Settings.
> 
> The setting is disabled on iOS. However, I need the ITP quirk on iOS as well. We could enable the setting on iOS but then it would enable other quirks than ITP on iOS, which would be risky at this point.

Ah, so site-specific quirks have been non-iOS-only up until now. That seems sloppy and seems worth cleaning up when we have a chance.

[Brent Fulgham]

<rdar://problem/33465715>