Bug 174676

Summary:

Drop legacy FileException type

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

DOM

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, buildbot, cdumez, commit-queue, darin, ggaren, rniwa, sam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

URL:

https://w3c.github.io/FileAPI/#ErrorAndException

Bug Depends on:

Bug Blocks:

174677

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews103 for mac-elcapitan	none
Archive of layout-test-results from ews116 for mac-elcapitan	none
Patch	none

Chris Dumez

Reported 2017-07-20 09:15:29 PDT

Drop legacy FileException type and use DOMException instead, as per the latest File API specification. Both Firefox and Chrome no longer expose FileException.

Attachments
Patch (30.41 KB, patch) 2017-07-20 10:03 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1011.67 KB, application/zip) 2017-07-20 11:02 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-elcapitan (1.78 MB, application/zip) 2017-07-20 11:25 PDT, Build Bot	no flags	Details
Patch (32.37 KB, patch) 2017-07-20 12:01 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2017-07-20 10:03:27 PDT

Created attachment 315995 [details] Patch

Build Bot

Comment 2 2017-07-20 11:02:02 PDT

Comment on attachment 315995 [details] Patch Attachment 315995 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4156299 New failing tests: fast/files/workers/worker-read-file-sync.html fast/files/workers/worker-read-blob-sync.html

Build Bot

Comment 3 2017-07-20 11:02:04 PDT

Created attachment 316002 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 4 2017-07-20 11:25:48 PDT

Comment on attachment 315995 [details] Patch Attachment 315995 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4156319 New failing tests: fast/files/workers/worker-read-file-sync.html fast/files/workers/worker-read-blob-sync.html

Build Bot

Comment 5 2017-07-20 11:25:49 PDT

Created attachment 316004 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Chris Dumez

Comment 6 2017-07-20 12:01:16 PDT

Created attachment 316010 [details] Patch

WebKit Commit Bot

Comment 7 2017-07-20 13:35:16 PDT

Comment on attachment 316010 [details] Patch Clearing flags on attachment: 316010 Committed r219699: <http://trac.webkit.org/changeset/219699>

WebKit Commit Bot

Comment 8 2017-07-20 13:35:18 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.