Bug 174642

Summary: [WebIDL] Remove custom bindings for CommandLineAPIHost
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, joepeck
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Sam Weinig
Reported 2017-07-18 13:18:06 PDT
[WebIDL] Remove custom bindings for CommandLineAPIHost
Attachments
Patch (20.14 KB, patch)
2017-07-18 13:52 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2017-07-18 13:52:21 PDT
Created attachment 315830 [details] Patch
Joseph Pecoraro
Comment 2 2017-07-19 12:02:39 PDT
Comment on attachment 315830 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315830&action=review > Source/WebCore/inspector/CommandLineAPIHost.idl:46 > + DOMString databaseId(Database? database); > + DOMString storageId(Storage? storage); We should be able to make these non-optional. We only call them with real values (CommandLineAPIModuleSource.js calls to CommandLineAPIHost.databaseId and CommandLineAPIHost.storageId).
Sam Weinig
Comment 3 2017-07-19 22:15:09 PDT
(In reply to Joseph Pecoraro from comment #2) > Comment on attachment 315830 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=315830&action=review > > > Source/WebCore/inspector/CommandLineAPIHost.idl:46 > > + DOMString databaseId(Database? database); > > + DOMString storageId(Storage? storage); > > We should be able to make these non-optional. We only call them with real > values (CommandLineAPIModuleSource.js calls to CommandLineAPIHost.databaseId > and CommandLineAPIHost.storageId). I'll do that in a follow up.
WebKit Commit Bot
Comment 4 2017-07-19 22:46:34 PDT
Comment on attachment 315830 [details] Patch Clearing flags on attachment: 315830 Committed r219675: <http://trac.webkit.org/changeset/219675>
WebKit Commit Bot
Comment 5 2017-07-19 22:46:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.