Bug 174630 – DOMException should not have its own toString()

• Component: DOM
• Status: RESOLVED FIXED

[Chris Dumez]

DOMException should not have its own toString() and should use the one from Error.prototype.toString() instead.

[Chris Dumez]

Created attachment 315795 [details]
Patch

[Build Bot]

Comment on attachment 315795 [details]
Patch

Attachment 315795 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4142166

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 315796 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Chris Dumez]

Looks like a lot of tests will need rebaselining.

[Build Bot]

Comment on attachment 315795 [details]
Patch

Attachment 315795 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4142249

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 315800 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 315795 [details]
Patch

Attachment 315795 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4142234

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 315801 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 315795 [details]
Patch

Attachment 315795 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4142276

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 315802 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Chris Dumez]

Created attachment 315825 [details]
Patch

[Build Bot]

Comment on attachment 315825 [details]
Patch

Attachment 315825 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4143526

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 315831 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 315825 [details]
Patch

Attachment 315825 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4143574

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 315832 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 315825 [details]
Patch

Attachment 315825 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4143594

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 315834 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Chris Dumez]

Created attachment 315835 [details]
Patch

[Chris Dumez]

Created attachment 315837 [details]
Patch

[Build Bot]

Comment on attachment 315837 [details]
Patch

Attachment 315837 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4143869

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 315842 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 315837 [details]
Patch

Attachment 315837 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4143897

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 315843 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 315837 [details]
Patch

Attachment 315837 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4144002

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 315845 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 315837 [details]
Patch

Attachment 315837 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4143974

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 315846 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Chris Dumez]

Created attachment 315849 [details]
Patch

[Chris Dumez]

Created attachment 315859 [details]
Patch

[Build Bot]

Comment on attachment 315859 [details]
Patch

Attachment 315859 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4145170

New failing tests:
imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSA-PSS.worker.html
svg/custom/acid3-test-77.html
crypto/subtle/rsa-import-key-malformed-parameters.html
imported/w3c/web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.worker.html
imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_successes_RSA-PSS.https.html
crypto/subtle/rsa-generate-key-malformed-parameters.html
fast/text/font-selection-font-loading-api-parse.html

[Build Bot]

Created attachment 315874 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 315859 [details]
Patch

Attachment 315859 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4145178

New failing tests:
fast/forms/date/date-stepup-stepdown.html
fast/forms/week/input-valueasnumber-week.html
imported/w3c/web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.worker.html
fast/forms/time/time-setrangetext.html
fast/forms/time/time-valueasnumber.html
crypto/subtle/rsa-generate-key-malformed-parameters.html
fast/forms/date/date-setrangetext.html
fast/forms/datetimelocal/datetimelocal-stepup-stepdown.html
fast/forms/datetimelocal/datetimelocal-setrangetext.html
fast/forms/time/time-stepup-stepdown.html
imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSA-PSS.worker.html
fast/forms/datetimelocal/input-valueasnumber-datetimelocal.html
imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.https.html
fast/forms/month/input-valueasdate.html
fast/forms/month/month-setrangetext.html
fast/forms/date/input-valueasnumber-date.html
fast/forms/month/month-stepup-stepdown.html
imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_successes_RSA-PSS.https.html
fast/forms/week/week-stepup-stepdown.html
fast/text/font-selection-font-loading-api-parse.html
svg/custom/acid3-test-77.html
crypto/subtle/rsa-import-key-malformed-parameters.html
fast/forms/month/input-valueasnumber-month.html
fast/forms/week/week-setrangetext.html

[Build Bot]

Created attachment 315875 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Build Bot]

Comment on attachment 315859 [details]
Patch

Attachment 315859 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4145180

New failing tests:
imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSA-PSS.worker.html
svg/custom/acid3-test-77.html
crypto/subtle/rsa-import-key-malformed-parameters.html
imported/w3c/web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.worker.html
imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_successes_RSA-PSS.https.html
crypto/subtle/rsa-generate-key-malformed-parameters.html
fast/text/font-selection-font-loading-api-parse.html

[Build Bot]

Created attachment 315876 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Chris Dumez]

Created attachment 315877 [details]
Patch

[Build Bot]

Comment on attachment 315877 [details]
Patch

Attachment 315877 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4145430

New failing tests:
svg/custom/acid3-test-77.html
crypto/subtle/rsa-generate-key-malformed-parameters.html

[Build Bot]

Created attachment 315880 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 315877 [details]
Patch

Attachment 315877 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4145437

New failing tests:
svg/custom/acid3-test-77.html
crypto/subtle/rsa-generate-key-malformed-parameters.html

[Build Bot]

Created attachment 315881 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 315877 [details]
Patch

Attachment 315877 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4145454

New failing tests:
fast/forms/date/date-stepup-stepdown.html
fast/forms/month/month-stepup-stepdown.html
fast/forms/time/time-stepup-stepdown.html
fast/forms/week/input-valueasnumber-week.html
fast/forms/date/input-valueasnumber-date.html
svg/custom/acid3-test-77.html
fast/forms/datetimelocal/input-valueasnumber-datetimelocal.html
fast/forms/month/input-valueasnumber-month.html
fast/forms/week/week-stepup-stepdown.html
crypto/subtle/rsa-generate-key-malformed-parameters.html
imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.https.html
fast/forms/date/date-setrangetext.html
fast/forms/datetimelocal/datetimelocal-stepup-stepdown.html
fast/forms/month/input-valueasdate.html
fast/forms/time/time-valueasnumber.html

[Build Bot]

Created attachment 315882 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Build Bot]

Comment on attachment 315877 [details]
Patch

Attachment 315877 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4145468

New failing tests:
svg/custom/acid3-test-77.html
crypto/subtle/rsa-generate-key-malformed-parameters.html

[Build Bot]

Created attachment 315883 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Chris Dumez]

Created attachment 315886 [details]
Patch

[Build Bot]

Comment on attachment 315886 [details]
Patch

Attachment 315886 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4145870

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 315889 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 315886 [details]
Patch

Attachment 315886 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4145874

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 315890 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 315886 [details]
Patch

Attachment 315886 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4145873

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 315892 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 315886 [details]
Patch

Attachment 315886 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4145891

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 315896 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Chris Dumez]

Created attachment 315901 [details]
Patch

[Build Bot]

Comment on attachment 315901 [details]
Patch

Attachment 315901 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4146308

New failing tests:
fast/forms/month/input-valueasdate.html

[Build Bot]

Created attachment 315906 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Chris Dumez]

Created attachment 315921 [details]
Patch

[Sam Weinig]

Comment on attachment 315921 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315921&action=review

> Source/WebCore/dom/DOMCoreException.idl:-41


What about the implementation of toString() in ExceptionBase? Can we get rid of that too?

[Chris Dumez]

(In reply to Sam Weinig from comment #58)
> Comment on attachment 315921 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=315921&action=review
> 
> > Source/WebCore/dom/DOMCoreException.idl:-41
> 
> 
> What about the implementation of toString() in ExceptionBase? Can we get rid
> of that too?

I'll check but I don't think so yet. I believe we still have other legacy subclasses to kill first :(

[Chris Dumez]

(In reply to Chris Dumez from comment #59)
> (In reply to Sam Weinig from comment #58)
> > Comment on attachment 315921 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=315921&action=review
> > 
> > > Source/WebCore/dom/DOMCoreException.idl:-41
> > 
> > 
> > What about the implementation of toString() in ExceptionBase? Can we get rid
> > of that too?
> 
> I'll check but I don't think so yet. I believe we still have other legacy
> subclasses to kill first :(

See IDBDatabaseException / SQLException / FileException / SVGException / XPathException. Those likely should not exist anymore.

[Chris Dumez]

Anyone interesting in reviewing?

[Sam Weinig]

Comment on attachment 315921 [details]
Patch

I have no interest, but I will anyway.

[WebKit Commit Bot]

Comment on attachment 315921 [details]
Patch

Clearing flags on attachment: 315921

Committed r219663: <http://trac.webkit.org/changeset/219663>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.