Bug 174617

Summary: WebDriver: add a javascript atom to get the visible text
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebDriverAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, bburg, ews-watchlist, gyuyoung.kim, pangle, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=238335
https://bugs.webkit.org/show_bug.cgi?id=270215
Bug Depends on:    
Bug Blocks: 166679    
Attachments:
Description Flags
Patch aperez: review+, ews-feeder: commit-queue-

Carlos Garcia Campos
Reported 2017-07-18 00:44:42 PDT
We are currently returning innerText with whitespaces cleaned, but the spec says we should return someting more complex, equivalent to what the selenium atoms do. "Let rendered text be the result of performing implementation-specific steps that are exactly analogous to the result of a [[Call]] to bot.dom.getVisibleText, providing null as the this value, and element as the argument." https://www.w3.org/TR/webdriver/#get-element-text
Attachments
Patch (38.93 KB, patch)
2022-02-04 06:13 PST, Carlos Garcia Campos 		aperez: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2017-07-19 15:09:33 PDT
<rdar://problem/32307461>
Carlos Garcia Campos
Comment 2 2022-02-04 06:13:02 PST
Created attachment 450885 [details] Patch
Carlos Garcia Campos
Comment 3 2022-02-04 06:14:06 PST
*** Bug 184964 has been marked as a duplicate of this bug. ***
Patrick Angle
Comment 4 2022-02-07 09:00:55 PST
Comment on attachment 450885 [details] Patch Approach looks go to me as well until we can move to JS Built-ins for these scripts.
Carlos Garcia Campos
Comment 5 2022-02-09 05:49:23 PST
Committed r289467 (247010@trunk): <https://commits.webkit.org/247010@trunk>
Note You need to log in before you can comment on or make changes to this bug.