Bug 174613

Summary:

WebDriver: implement cookies commands

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, buildbot, joepeck, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

166679

Attachments:

Description	Flags
Patch	bburg: review+

Carlos Garcia Campos

Reported 2017-07-18 00:28:39 PDT

https://www.w3.org/TR/webdriver/#cookies

Attachments
Patch (23.31 KB, patch) 2017-08-16 09:11 PDT, Carlos Garcia Campos	bburg: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Carlos Garcia Campos

Comment 1 2017-08-16 09:11:46 PDT

Created attachment 318263 [details] Patch

Build Bot

Comment 2 2017-08-16 09:13:45 PDT

Attachment 318263 [details] did not pass style-queue: ERROR: Source/WebDriver/Session.h:107: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/Session.h:108: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/Session.h:109: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/Session.h:110: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/Session.h:111: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/WebDriverService.cpp:1283: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/WebDriverService.cpp:1300: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/WebDriverService.cpp:1367: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/WebDriverService.cpp:1396: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/WebDriverService.cpp:1419: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/WebDriverService.h:103: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/WebDriverService.h:104: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/WebDriverService.h:105: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/WebDriverService.h:106: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/WebDriverService.h:107: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/Session.cpp:1778: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/Session.cpp:1824: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/Session.cpp:1848: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/Session.cpp:1873: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebDriver/Session.cpp:1898: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 20 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Blaze Burg

Comment 3 2017-08-18 12:23:37 PDT

Comment on attachment 318263 [details] Patch r=me

Carlos Garcia Campos

Comment 4 2017-08-28 04:53:06 PDT

Committed r221241: <http://trac.webkit.org/changeset/221241>

Radar WebKit Bug Importer

Comment 5 2017-08-28 04:57:18 PDT

<rdar://problem/34108580>

Note You need to log in before you can comment on or make changes to this bug.