Bug 174608

Summary: Remove WebIconDatabase from WebKitLegacy/win
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, aestes, buildbot, commit-queue, sam, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Brady Eidson
Reported 2017-07-17 20:47:43 PDT
Remove WebIconDatabase from WebKitLegacy/win Nobody uses it.
Attachments
Patch (33.85 KB, patch)
2017-07-17 20:50 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (34.32 KB, patch)
2017-07-18 21:11 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (34.90 KB, patch)
2017-07-18 22:49 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (38.02 KB, patch)
2017-07-19 20:07 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2017-07-17 20:50:01 PDT
Created attachment 315763 [details] Patch
Build Bot
Comment 2 2017-07-17 20:52:37 PDT
Attachment 315763 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/win/WebView.cpp:3226: Tab found; better to use spaces [whitespace/tab] [1] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 3 2017-07-18 21:11:38 PDT
Created attachment 315885 [details] Patch
Brady Eidson
Comment 4 2017-07-18 22:49:50 PDT
Created attachment 315898 [details] Patch
Brady Eidson
Comment 5 2017-07-19 20:07:16 PDT
Created attachment 315966 [details] Patch
WebKit Commit Bot
Comment 6 2017-07-20 07:30:13 PDT
Comment on attachment 315966 [details] Patch Clearing flags on attachment: 315966 Committed r219684: <http://trac.webkit.org/changeset/219684>
WebKit Commit Bot
Comment 7 2017-07-20 07:30:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.