Bug 174606

Summary:

[WebIDL] Remove custom bindings for MockContentFilterSettings

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, buildbot, commit-queue, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-elcapitan	none
Archive of layout-test-results from ews112 for mac-elcapitan	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none
Patch	none

Sam Weinig

Reported 2017-07-17 20:36:24 PDT

[WebIDL] Remove custom bindings for MockContentFilterSettings

Attachments
Patch (32.54 KB, patch) 2017-07-17 20:42 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (12.17 KB, patch) 2017-07-17 22:47 PDT, Sam Weinig	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-elcapitan (1.10 MB, application/zip) 2017-07-17 23:53 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews112 for mac-elcapitan (1.89 MB, application/zip) 2017-07-18 00:21 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (9.12 MB, application/zip) 2017-07-18 00:27 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.71 MB, application/zip) 2017-07-18 00:30 PDT, Build Bot	no flags	Details
Patch (32.54 KB, patch) 2017-07-18 11:47 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2017-07-17 20:42:57 PDT

Created attachment 315762 [details] Patch

Sam Weinig

Comment 2 2017-07-17 22:47:16 PDT

Created attachment 315767 [details] Patch

Build Bot

Comment 3 2017-07-17 23:53:04 PDT

Comment on attachment 315767 [details] Patch Attachment 315767 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4139987 New failing tests: http/tests/contentfiltering/block-after-redirect.html contentfiltering/modify-request-url.html contentfiltering/block-after-response-then-deny-unblock.html contentfiltering/block-after-finished-adding-data-then-deny-unblock.html contentfiltering/block-after-will-send-request-then-allow-unblock.html http/tests/contentfiltering/modify-redirect-request-url.html contentfiltering/block-after-add-data.html contentfiltering/block-after-add-data-then-deny-unblock.html contentfiltering/block-after-add-data-then-allow-unblock.html contentfiltering/block-after-response.html contentfiltering/block-after-response-then-allow-unblock.html contentfiltering/block-after-will-send-request.html contentfiltering/block-after-finished-adding-data.html contentfiltering/block-after-will-send-request-then-deny-unblock.html contentfiltering/block-after-finished-adding-data-then-allow-unblock.html

Build Bot

Comment 4 2017-07-17 23:53:05 PDT

Created attachment 315772 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 5 2017-07-18 00:21:53 PDT

Comment on attachment 315767 [details] Patch Attachment 315767 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4140058 New failing tests: http/tests/contentfiltering/block-after-redirect.html contentfiltering/modify-request-url.html contentfiltering/block-after-response-then-deny-unblock.html contentfiltering/block-after-finished-adding-data-then-deny-unblock.html contentfiltering/block-after-will-send-request-then-allow-unblock.html http/tests/contentfiltering/modify-redirect-request-url.html contentfiltering/block-after-add-data.html contentfiltering/block-after-add-data-then-deny-unblock.html contentfiltering/block-after-add-data-then-allow-unblock.html contentfiltering/block-after-response.html contentfiltering/block-after-response-then-allow-unblock.html contentfiltering/block-after-will-send-request.html contentfiltering/block-after-finished-adding-data.html contentfiltering/block-after-will-send-request-then-deny-unblock.html contentfiltering/block-after-finished-adding-data-then-allow-unblock.html

Build Bot

Comment 6 2017-07-18 00:21:54 PDT

Created attachment 315773 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 7 2017-07-18 00:27:19 PDT

Comment on attachment 315767 [details] Patch Attachment 315767 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4140080 New failing tests: http/tests/contentfiltering/block-after-redirect.html contentfiltering/modify-request-url.html contentfiltering/block-after-response-then-deny-unblock.html contentfiltering/block-after-finished-adding-data-then-deny-unblock.html contentfiltering/block-after-will-send-request-then-allow-unblock.html http/tests/contentfiltering/modify-redirect-request-url.html contentfiltering/block-after-add-data.html contentfiltering/block-after-add-data-then-deny-unblock.html contentfiltering/block-after-add-data-then-allow-unblock.html contentfiltering/block-after-response.html contentfiltering/block-after-response-then-allow-unblock.html contentfiltering/block-after-will-send-request.html contentfiltering/block-after-finished-adding-data.html contentfiltering/block-after-will-send-request-then-deny-unblock.html contentfiltering/block-after-finished-adding-data-then-allow-unblock.html

Build Bot

Comment 8 2017-07-18 00:27:20 PDT

Created attachment 315775 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5

Build Bot

Comment 9 2017-07-18 00:30:13 PDT

Comment on attachment 315767 [details] Patch Attachment 315767 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4140079 New failing tests: http/tests/contentfiltering/block-after-redirect.html contentfiltering/modify-request-url.html contentfiltering/block-after-response-then-deny-unblock.html contentfiltering/block-after-finished-adding-data-then-deny-unblock.html contentfiltering/block-after-will-send-request-then-allow-unblock.html http/tests/contentfiltering/modify-redirect-request-url.html contentfiltering/block-after-add-data.html contentfiltering/block-after-add-data-then-deny-unblock.html contentfiltering/block-after-add-data-then-allow-unblock.html contentfiltering/block-after-response.html contentfiltering/block-after-response-then-allow-unblock.html contentfiltering/block-after-will-send-request.html contentfiltering/block-after-finished-adding-data.html contentfiltering/block-after-will-send-request-then-deny-unblock.html contentfiltering/block-after-finished-adding-data-then-allow-unblock.html

Build Bot

Comment 10 2017-07-18 00:30:14 PDT

Created attachment 315776 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Sam Weinig

Comment 11 2017-07-18 08:24:00 PDT

Heh. Forgot to upload test changes

Sam Weinig

Comment 12 2017-07-18 11:47:44 PDT

Created attachment 315808 [details] Patch

WebKit Commit Bot

Comment 13 2017-07-18 13:14:35 PDT

Comment on attachment 315808 [details] Patch Clearing flags on attachment: 315808 Committed r219623: <http://trac.webkit.org/changeset/219623>

WebKit Commit Bot

Comment 14 2017-07-18 13:14:36 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.