Bug 174593

Summary: InsertOrderedList command applied to table cells inserts an extra BR before the table
Product: WebKit Reporter: Javier Fernandez <jfernandez>
Component: HTML EditingAssignee: Javier Fernandez <jfernandez>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, darin, jfernandez, rego, rniwa, wenson_hsieh
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.chromium.org/p/chromium/issues/detail?id=744936
Attachments:
Description Flags
Test case to reproduce the bug
none
Patch
none
Archive of layout-test-results from ews124 for ios-simulator-wk2
none
Patch
none
Archive of layout-test-results from ews125 for ios-simulator-wk2
none
Patch none

Description Javier Fernandez 2017-07-17 14:07:08 PDT
Created attachment 315709 [details]
Test case to reproduce the bug

What steps will reproduce the problem?
(1) Load the attached test case. The contents of the table will be selected on load
(2) Hit the "List" button multiple times. 

What is the expected result?

The cell content become a list item after the first click. List items become regular text after a new click. Subsequent clicks will produce the same results.

What happens instead?

On every second click, the table will move down.
Comment 1 Javier Fernandez 2017-07-21 06:17:19 PDT
Created attachment 316084 [details]
Patch
Comment 2 Build Bot 2017-07-21 07:43:33 PDT
Comment on attachment 316084 [details]
Patch

Attachment 316084 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4161444

New failing tests:
editing/inserting/insert-list-in-table-cell-07.html
editing/inserting/insert-list-in-table-cell-03.html
Comment 3 Build Bot 2017-07-21 07:43:35 PDT
Created attachment 316086 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 4 Javier Fernandez 2017-07-21 14:22:56 PDT
Created attachment 316122 [details]
Patch
Comment 5 Build Bot 2017-07-21 17:06:54 PDT
Comment on attachment 316122 [details]
Patch

Attachment 316122 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4164195

Number of test failures exceeded the failure limit.
Comment 6 Build Bot 2017-07-21 17:06:55 PDT
Created attachment 316147 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 7 Javier Fernandez 2017-07-23 14:07:35 PDT
Created attachment 316235 [details]
Patch
Comment 8 WebKit Commit Bot 2017-07-26 02:48:41 PDT
Comment on attachment 316235 [details]
Patch

Clearing flags on attachment: 316235

Committed r219914: <http://trac.webkit.org/changeset/219914>
Comment 9 WebKit Commit Bot 2017-07-26 02:48:42 PDT
All reviewed patches have been landed.  Closing bug.