Summary: | [iOS DnD] Web process uses too much memory when beginning a drag on a very large image | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||||||
Component: | WebCore Misc. | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | aestes, bdakin, buildbot, commit-queue, megan_gardner, thorton | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Wenson Hsieh
2017-07-17 09:44:18 PDT
Created attachment 315672 [details]
Patch
Created attachment 315673 [details]
Rebase on master
Comment on attachment 315673 [details] Rebase on master Attachment 315673 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4136613 New failing tests: imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html http/tests/canvas/canvas-tainted-after-draw-image.html Created attachment 315686 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Comment on attachment 315673 [details] Rebase on master View in context: https://bugs.webkit.org/attachment.cgi?id=315673&action=review > Source/WebCore/platform/ios/DragImageIOS.mm:103 > + auto scaledWidth = std::round(std::sqrt(maximumAllowedDragImageArea * imageSize.width / imageSize.height)); > + adjustedImageScale = scaledWidth / imageSize.width; > + imageSize = { scaledWidth, std::round(maximumAllowedDragImageArea / scaledWidth) }; Is there a GeometryUtilities you could use here? Comment on attachment 315673 [details] Rebase on master View in context: https://bugs.webkit.org/attachment.cgi?id=315673&action=review > Tools/TestWebKitAPI/cocoa/TestWKWebView.mm:226 > +- (void)synchronouslyLoadHTML:(NSString *)html HTMLString, I think, like WebKit (In reply to Tim Horton from comment #5) > Comment on attachment 315673 [details] > Rebase on master > > View in context: > https://bugs.webkit.org/attachment.cgi?id=315673&action=review > > > Source/WebCore/platform/ios/DragImageIOS.mm:103 > > + auto scaledWidth = std::round(std::sqrt(maximumAllowedDragImageArea * imageSize.width / imageSize.height)); > > + adjustedImageScale = scaledWidth / imageSize.width; > > + imageSize = { scaledWidth, std::round(maximumAllowedDragImageArea / scaledWidth) }; > > Is there a GeometryUtilities you could use here? It doesn't look like there's anything that just computes an area with a given size and aspect ratio. I can add this to GeometryUtilities -- does FloatSize sizeWithAreaAndAspectRatio(float area, float size); sound okay? Created attachment 315714 [details]
Patch for landing
The commit-queue encountered the following flaky tests while processing attachment 315714 [details]: storage/indexeddb/modern/new-database-after-user-delete.html bug 174354 (author: beidson@apple.com) The commit-queue is continuing to process your patch. The commit-queue encountered the following flaky tests while processing attachment 315714 [details]:
The commit-queue is continuing to process your patch.
Comment on attachment 315714 [details] Patch for landing Clearing flags on attachment: 315714 Committed r219585: <http://trac.webkit.org/changeset/219585> |