Bug 174546

Summary: [CMake] Include most CMake modules from WebKitCommon.cmake
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, bugs-noreply, commit-queue, mcatanzaro
Priority: P2    
Version: Other   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2017-07-15 11:09:09 PDT
When creating WebCoreMacros.cmake, I forgot to move some includes from WebKitMacros.cmake: include(CMakeParseArguments) include(ProcessorCount) ProcessorCount(PROCESSOR_COUNT)
Attachments
Patch (7.03 KB, patch)
2017-07-17 12:10 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2017-07-15 14:30:34 PDT
"include" command of cmake (just like #include in C preprocessor) has no protection against multiple inclusion of the same file ("module"). Some built-in modules implement ad-hoc protection, but not all of them. It can be a better idea to include built-in cmake modules in shared cmake files instead of moving them down to "subprojects", and maybe even move them all to the root CMakeLists.txt or to new file like Source/cmake/Includes.cmake
Michael Catanzaro
Comment 2 2017-07-15 20:43:21 PDT
I hate CMake....
Konstantin Tokarev
Comment 3 2017-07-16 02:09:40 PDT
Another way is to introduce wrapper for include() that will implement protection, so that it can be used everywhere without limits
Michael Catanzaro
Comment 4 2017-07-17 12:10:39 PDT
Created attachment 315689 [details] Patch
WebKit Commit Bot
Comment 5 2017-07-17 15:50:43 PDT
Comment on attachment 315689 [details] Patch Clearing flags on attachment: 315689 Committed r219580: <http://trac.webkit.org/changeset/219580>
WebKit Commit Bot
Comment 6 2017-07-17 15:50:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.