Bug 174504
| Summary: | Marking a directory as [ Pass ] or [ Failure ] or [ Crash ] should not override test-specific expectations | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | jlewis3, lforschler, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Jonathan Bedard
Currently, when we mark an entire directory as something, we simply recursively mark every test in that directory as Pass/Failure/Crash/Skip. We should be smarter about this, particularly with 'Pass.' For example:
TestExpectations: edit/mac [ Skip ]
platform/wk2/TestExpectations: edit/mac/some-test.html [ Failure ] # XYZ is not implemented in WK2
platform/mac/TestExpectations: edit/mac [ Pass ] # Now edit/mac/some-test.html is marked as passing
This results in 1) duplicated expectations, 2) bugs separated across expectation files and 3) it being difficult to garden tests since platforms frequently mark entire directories as [ Pass ] when those platforms support a feature which their more general parent platform does not. (ie: Mac generally may not support a given feature, but Sierra might).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/33317289>
Jonathan Bedard
I spoke with Ryan Haddad and Dan Bates about this proposal on 8/25. It seems that what I'm suggesting would not be an improvement over the current behavior. Closing this bug.