Bug 17449
| Summary: | JSCore fails to compile on PPC/Linux (asm error) | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Patryk Zawadzki <patrys> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Major | CC: | lars, patrys |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | Linux | ||
Patryk Zawadzki
Full build log:
http://buildlogs.pld-linux.org/index.php?dist=th&arch=ppc&ok=0&id=04ce61f5ca498f557d01389b26c198e8
Likely most interesting part:
ppc-pld-linux-g++ -DHAVE_CONFIG_H -I. -I./JavaScriptCore -I./JavaScriptCore/ForwardingHeaders -I./JavaScriptCore/wtf -I./JavaScriptCore/kjs -I./DerivedSources -DBUILDING_GTK__=1 -DWTF_CHANGES -DXP_UNIX -DNDEBUG -DENABLE_ICONDATABASE=0 -I./JavaScriptCore/ForwardingHeaders -I./JavaScriptCore/bindings -I./JavaScriptCore/bindings/c -I./JavaScriptCore/pcre -I./JavaScriptCore/kjs -D_REENTRANT -I/usr/include -fvisibility-inlines-hidden -fno-rtti -Wall -W -Wcast-align -Wchar-subscripts -Wreturn-type -Wformat -Wformat-security -Wno-format-y2k -Wundef -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings -Wno-unused-parameter -fno-exceptions -fvisibility=hidden -fstrict-aliasing -O2 -fno-strict-aliasing -fwrapv -fsigned-char -gdwarf-2 -g2 -MT JavaScriptCore/kjs/libJavaScriptCore_la-AllInOneFile.lo -MD -MP -MF JavaScriptCore/kjs/.deps/libJavaScriptCore_la-AllInOneFile.Tpo -c JavaScriptCore/kjs/AllInOneFile.cpp -fPIC -DPIC -o JavaScriptCore/kjs/.libs/libJavaScriptCore_la-AllInOneF
ile.o
/tmp/B.3f6d88/ccNNmo7l.s: Assembler messages:
/tmp/B.3f6d88/ccNNmo7l.s:41842: Error: syntax error; found `,' but expected `('
/tmp/B.3f6d88/ccNNmo7l.s:41842: Error: junk at end of line: `,11'
make[1]: *** [JavaScriptCore/kjs/libJavaScriptCore_la-AllInOneFile.lo] Error 1
make[1]: Leaving directory `/home/users/builder/rpm/BUILD/WebKit-r30377'
As you can see, this is r30377 but also happened with r30153 and r30122. This is a WebKitGtk build but that should not matter.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Patryk Zawadzki
*** Bug 17741 has been marked as a duplicate of this bug. ***
Arkadiusz Miskiewicz
This should fix it.
--- JavaScriptCore/wtf/TCSpinLock.h~ 2008-02-26 01:15:08.000000000 +0100
+++ JavaScriptCore/wtf/TCSpinLock.h 2008-03-14 23:30:07.361354727 +0100
@@ -104,7 +104,7 @@
("isync\n\t"
"eieio\n\t"
"stw %1, %0"
-#if PLATFORM(DARWIN)
+#if PLATFORM(DARWIN) || PLATFORM(PPC)
: "=o" (lockword_)
#else
: "=m" (lockword_)
Patryk Zawadzki
Confirmed. The patch fixed the PPC build.
David Kilzer (:ddkilzer)
*** This bug has been marked as a duplicate of 17019 ***