Bug 174467 – Incorrect assertion in JSC::CallLinkInfo::callTypeFor

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Michael Catanzaro]

In CallLinkInfo::callTypeFor, the assertion ASSERT(opcodeID == op_tail_call_varargs || op_tail_call_forward_arguments) should surely be ASSERT(opcodeID == op_tail_call_varargs || opcodeID == op_tail_call_forward_arguments). Currently it always passes because op_tail_call_forward_arguments is nonzero.

This was introduced in r205462. It's found by a new GCC warning:

[522/5861] Building CXX object Source/...ptCore.dir/bytecode/CallLinkInfo.cpp.o
In file included from ../../Source/WTF/wtf/StdLibExtras.h:33:0,
                 from ../../Source/WTF/wtf/FastMalloc.h:26,
                 from ../../Source/JavaScriptCore/config.h:31,
                 from ../../Source/JavaScriptCore/bytecode/CallLinkInfo.cpp:26:
../../Source/JavaScriptCore/bytecode/CallLinkInfo.cpp: In static member function ‘static JSC::CallLinkInfo::CallType JSC::CallLinkInfo::callTypeFor(JSC::OpcodeID)’:
../../Source/JavaScriptCore/bytecode/CallLinkInfo.cpp:54:48: warning: enum constant in boolean context [-Wint-in-bool-context]
     ASSERT(opcodeID == op_tail_call_varargs || op_tail_call_forward_arguments);
                                                ^
../../Source/WTF/wtf/Assertions.h:296:11: note: in definition of macro ‘ASSERT’
     if (!(assertion)) { \
           ^~~~~~~~~

[Michael Catanzaro]

Created attachment 315358 [details]
Patch

[Michael Catanzaro]

Let's hope the assertion does not get hit now that it will be active!

[WebKit Commit Bot]

Comment on attachment 315358 [details]
Patch

Clearing flags on attachment: 315358

Committed r219462: <http://trac.webkit.org/changeset/219462>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.