Bug 17445 – [GTK] WebKit doesn't compile with LDFLAGS="-Wl,--as-needed"

• Component: New Bugs
• Status: RESOLVED FIXED

[Mike Auty]

The GNUmakefile.am files make use of the LDFLAGS variable to include library additions such as -ljpeg etc.  Unfortunately, if these inclusions aren't made in LIBADD/LDADD variables, then they are mis-ordered during the linking.

The as-needed flag discards libraries whose functions have not been needed by earlier libraries, which therefore makes the ordering important.

I'll be attaching a patch directly after this, built against a recent nightly build.  This could potentially affect other build systems/OSes, but I've only been able to confirm that the patch fixes the build issues on linux.

[Mike Auty]

Created attachment 19224 [details]
webkitgtk-30267-as-needed.patch

This moves all -l library inclusion statements from LDFLAGS variables to LIBADD/LDADD variables.  It applies cleanly against r30267.

If you require newer versions or any further information, please just ask.  5:)

[Alp Toker]

Comment on attachment 19224 [details]
webkitgtk-30267-as-needed.patch

r=me

Sorry about the delay.

I'll clean up a few whitespace mistakes in GNUmakefile.am and write a ChangeLog entry for you this time, but in future please look into doing these in your patches.

Thanks

[Alp Toker]

Landed in r30459. I also took out an unneeded -ljpeg from the GtkLauncher flags.