Summary: | REGRESSION(r219332): [GTK] 9 new failures on fast/forms spinbutton related tests | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||
Component: | WebKitGTK | Assignee: | Carlos Alberto Lopez Perez <clopez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bugs-noreply, cgarcia, clopez, dino, hyatt, mcatanzaro | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 173572 | ||||||
Attachments: |
|
Description
Carlos Alberto Lopez Perez
2017-07-11 15:21:02 PDT
Committed r219368: <http://trac.webkit.org/changeset/219368> Created attachment 315243 [details]
Patch
Comment on attachment 315243 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315243&action=review > Source/WebCore/ChangeLog:15 > + Before r219332 the height of the spin button was calculated as > + the maximum value between the arrow width (33 pixels) and the > + arrow height (16 pixels). > + r219332 caused the height to be calculated as the arrow height, > + which was incorrect as the arrow should be first expanded > + vertically to fit the preferred size of the spinbutton widget. There are no arrows in spin buttons, I guess you mean just the spin button itself here. (In reply to Carlos Garcia Campos from comment #3) > Comment on attachment 315243 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=315243&action=review > > > Source/WebCore/ChangeLog:15 > > + Before r219332 the height of the spin button was calculated as > > + the maximum value between the arrow width (33 pixels) and the > > + arrow height (16 pixels). > > + r219332 caused the height to be calculated as the arrow height, > > + which was incorrect as the arrow should be first expanded > > + vertically to fit the preferred size of the spinbutton widget. > > There are no arrows in spin buttons, I guess you mean just the spin button > itself here. Yes, with arrows I meant each one of the individual buttons (the [+] and the [-]). Committed r219447: <http://trac.webkit.org/changeset/219447> |