Bug 174344

Summary:

[Cocoa] Remove or update order files

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

achristensen, ahmad.saleem792, ap, bugs-noreply, buildbot, joepeck, keith_miller, mark.lam, mcatanzaro, msaboff, rniwa, saam, slewis

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[PATCH] Proposed Fix	rniwa: review+

Joseph Pecoraro

Reported 2017-07-10 19:53:32 PDT

Summary: We have a bunch of order files that haven't been meaningfully updated since 2013. They contain a lot of symbols that no longer exist. They also sometimes show up in my code searches. Can we eliminate these files? ./Source/WebKit/mac/WebKit.order ./Source/JavaScriptCore/JavaScriptCore.order ./Source/WebKit2/mac/WebKit2.order ./Source/WebCore/WebCore.order

Attachments
[PATCH] Proposed Fix (3.51 MB, patch) 2017-07-10 19:59 PDT, Joseph Pecoraro	rniwa: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2017-07-10 19:59:02 PDT

Created attachment 315066 [details] [PATCH] Proposed Fix

Alexey Proskuryakov

Comment 2 2017-07-10 20:49:42 PDT

We've been told that order files should still be helping performance, so it seems worth trying to update.

Alex Christensen

Comment 3 2017-07-11 10:45:28 PDT

I've been told that someone usually updates them right before a release.

Michael Catanzaro

Comment 4 2017-07-11 12:28:27 PDT

Just out of curiosity, since I've never heard of this and it turns out "order files" are impossible to search for... do they cause the symbols in the framework/library to be ordered in a particular way, and that somehow results in improved performance?

Stephanie Lewis

Comment 5 2017-07-11 15:35:48 PDT

Yes, using some internal profiling tools we order the symbols in a way that should improve locality. This has some memory benefits and also results in improved performance for HDDs. I normally try to do this in the last month before a release. The closer to release the better they'll match the shipping product. The last couple of times I've run it though I haven't been able to prove a performance win. Which meant for the last couple of years the task to do it has been punted in favor of other work.

Alex Christensen

Comment 6 2017-07-12 10:32:35 PDT

If we updated it right now they would match the shipping product *much* better than a list of symbols from 2013. I think we should update or remove them.

Joseph Pecoraro

Comment 7 2017-11-02 11:16:12 PDT

This is still reviewable. Its been nearly 4 months with no evidence that order files improve performance or not. Removing the files we'd at least be able to see on perf bots if there is any change.

Ryosuke Niwa

Comment 8 2017-11-02 14:21:10 PDT

Comment on attachment 315066 [details] [PATCH] Proposed Fix Let's remove it for now. It's really unhelpful to have these order files from 2013.

Ahmad Saleem

Comment 9 2024-03-11 05:56:30 PDT

*** This bug has been marked as a duplicate of bug 204959 ***

Note You need to log in before you can comment on or make changes to this bug.