Summary: | Web Inspector: [PARITY] Styles Redesign: Implement warning icons | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||
Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||
Status: | RESOLVED DUPLICATE | ||||||
Severity: | Normal | CC: | hi, inspector-bugzilla-changes, mattbaker, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | 145982 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
(In reply to Nikita Vasilyev from comment #0) > Created attachment 315049 [details] > [Image] Bug > > CSS warning icons in the styles sidebar should be on far left, and they > shouldn't shift text. > > Also, we should never show more than one warning icon per line. I remember addressing both of these in https://bugs.webkit.org/show_bug.cgi?id=170281. Was there a regression, or did that fix not cover all the situations where this can occur? Steps to reproduce? (In reply to Matt Baker from comment #2) > (In reply to Nikita Vasilyev from comment #0) > > Created attachment 315049 [details] > > [Image] Bug > > > > CSS warning icons in the styles sidebar should be on far left, and they > > shouldn't shift text. Agree, shifting the style text to make room is terrible. The icon could occupy the same position as the checkbox. It feels weird to be able to enable/disable a style with a warning/strikethrough, but maybe there is a use case here. > > > > Also, we should never show more than one warning icon per line. This was the issue I was thinking of. Can this still happen? > > I remember addressing both of these in > https://bugs.webkit.org/show_bug.cgi?id=170281. Was there a regression, or > did that fix not cover all the situations where this can occur? Steps to > reproduce? Retitling and converting this bug to a task. The new styles sidebar doesn't have any warning icons yet. The plan is to show at most one warning icon per property and show them on a side (not inline). *** This bug has been marked as a duplicate of bug 179215 *** |
Created attachment 315049 [details] [Image] Bug CSS warning icons in the styles sidebar should be on far left, and they shouldn't shift text. Also, we should never show more than one warning icon per line.