Bug 174312

Summary: Factor common code in Style::*ChangeInvalidation into helper functions
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kling, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
kling: review+
patch
none
patch none

Antti Koivisto
Reported 2017-07-10 08:47:36 PDT
There is a lot of copy code here.
Attachments
patch (18.65 KB, patch)
2017-07-10 09:25 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (20.79 KB, patch)
2017-07-10 09:53 PDT, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
patch (21.21 KB, patch)
2017-08-03 06:23 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (21.25 KB, patch)
2017-08-03 06:25 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2017-07-10 09:25:47 PDT
Created attachment 314990 [details] patch
Antti Koivisto
Comment 2 2017-07-10 09:53:49 PDT
Created attachment 314993 [details] patch
Andreas Kling
Comment 3 2017-07-10 22:18:57 PDT
Comment on attachment 314993 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=314993&action=review r=me > Source/WebCore/style/StyleInvalidationFunctions.h:38 > +template <typename Function> > +inline void traverseRuleFeaturesInShadowTree(Element& element, Function&& function) Does the Function argument need to be templated when you're only ever using it to pass a void(RuleFeatureSet&,bool)?
Antti Koivisto
Comment 4 2017-08-03 06:23:55 PDT
Created attachment 317117 [details] patch
Antti Koivisto
Comment 5 2017-08-03 06:25:17 PDT
Created attachment 317118 [details] patch
WebKit Commit Bot
Comment 6 2017-08-03 07:45:34 PDT
Comment on attachment 317118 [details] patch Clearing flags on attachment: 317118 Committed r220204: <http://trac.webkit.org/changeset/220204>
WebKit Commit Bot
Comment 7 2017-08-03 07:45:35 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2017-08-03 07:46:48 PDT
<rdar://problem/33699837>
Note You need to log in before you can comment on or make changes to this bug.