|Summary:||[SOUP] Remove WebKitSoupCookieJarSqlite|
|Product:||WebKit||Reporter:||Michael Catanzaro <mcatanzaro>|
|Component:||WebKitGTK||Assignee:||Michael Catanzaro <mcatanzaro>|
|Severity:||Normal||CC:||bugs-noreply, cgarcia, mcatanzaro|
Description Michael Catanzaro 2017-07-10 07:15:19 PDT
It seems WebKitSoupCookieJarSqlite uses exactly the same database format as the upstream SoupCookieJarDb class. WebKitSoupCookieJarSqlite exists only because SoupCookieJarDb is relatively new, and the older SoupCookieJarSqlite class existed only in libsoup-gnome rather than libsoup proper. The advantage of continuing to use our WebKitSoupCookieJarSqlite class, besides that we already know it works, is that it utilizes the same SQLiteDatabase class that is used elsewhere in WebKit. But that's not really any reason to keep the class around, when SoupCookieJarDb does exactly the same thing. It was introduced in libsoup 2.42 and that is already our minimum required version, so we can just switch. This passes a quick sanity-check of Epiphany's cookies dialog and also TestCookieManager.
Comment 2 Carlos Garcia Campos 2017-07-10 07:21:53 PDT
Comment on attachment 314978 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314978&action=review Thanks > Source/WebKit2/ChangeLog:8 > + It seems WebKitSoupCookieJarSqlite uses exactly the same database format as the upstream WebKitSoupCookieJarSqlite is a copy of SoupCookieJarSqlite but using WebKit sqlite implementation and other WTF stuff.