Bug 174286

Summary: [WK2 iOS] During momentum scroll, getBoundingClientRect returns wrong coordinates (missing images on pinterest, elle.com and many other sites)
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cmarcelo, dino, jamesr, luiz, simon.fraser, thorton, tonikitoo, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews124 for ios-simulator-wk2
none
Patch dino: review+

Description Simon Fraser (smfr) 2017-07-07 18:46:21 PDT
[WK2 iOS] During momentum scroll, getBoundingClientRect returns wrong coordinates (missing images on pinterest, elle.com and many other sites)
Comment 1 Simon Fraser (smfr) 2017-07-07 18:48:49 PDT
Created attachment 314905 [details]
Patch
Comment 2 Build Bot 2017-07-07 20:18:50 PDT
Comment on attachment 314905 [details]
Patch

Attachment 314905 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4074919

New failing tests:
scrollingcoordinator/ios/sync-layer-positions-after-scroll.html
Comment 3 Build Bot 2017-07-07 20:18:51 PDT
Created attachment 314912 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 4 Simon Fraser (smfr) 2017-07-10 19:58:00 PDT
Created attachment 315065 [details]
Patch
Comment 5 Dean Jackson 2017-07-10 20:00:56 PDT
Comment on attachment 315065 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315065&action=review

> Source/WebCore/ChangeLog:19
> +        but fix the scrolling tree logic to work correctly in this cause.

Typo: cause

> LayoutTests/fast/visual-viewport/ios/get-bounding-client-rect-unstable.html:49
> +            testRunner.runUIScript(simulateScrollingStart(500), function() {
> +                checkBoundingClientRect(-150);
> +
> +                debug('Finishing scroll');
> +                testRunner.runUIScript(simulateScrollingEnd(), function() {

Is it ok to call a UIScript from within a UIScript?
Comment 6 Simon Fraser (smfr) 2017-07-10 20:04:08 PDT
rdar://problem/32864180
Comment 7 Simon Fraser (smfr) 2017-07-10 20:42:26 PDT
https://trac.webkit.org/r219320