Bug 174260

Summary:

REGRESSION(r219194): [GStreamer] http/tests/media/video-redirect.html is failing

Product:

WebKit

Reporter:

Charlie Turner <cturner>

Component:

WebKitGTK

Assignee:

Charlie Turner <cturner>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bugs-noreply, cgarcia, clopez, commit-queue, mcatanzaro

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Charlie Turner 2017-07-07 10:12:08 PDT

This was some fallout from r219194. The reason was not omitting an extra place we needed to convert URL's to using our internal protocol schema.
These workarounds can go away once the upstream bug to be able to set ranks per-element get in.

Comment 1 Charlie Turner 2017-07-07 12:35:25 PDT

Created attachment 314861 [details]
Patch

Comment 2 Carlos Alberto Lopez Perez 2017-07-09 17:35:47 PDT

Comment on attachment 314861 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314861&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:229
> -    m_url = URL(URL(), cleanURLString);
> +    URL cleanURL = URL(URL(), cleanURLString);
> +    convertToInternalProtocol(cleanURL);
>  
> -    if (m_url.protocolIsInHTTPFamily())
> -        m_url.setProtocol("webkit+" + url.protocol());
> +    m_url = cleanURL;

Why using an extra variable cleanURL and not simply doing ...

m_url = URL(URL(), cleanURLString);
convertToInternalProtocol(m_url);


??

Comment 3 Charlie Turner 2017-07-10 01:45:18 PDT

Created attachment 314969 [details]
Patch

Comment 4 WebKit Commit Bot 2017-07-10 03:13:50 PDT

Comment on attachment 314969 [details]
Patch

Clearing flags on attachment: 314969

Committed r219288: <http://trac.webkit.org/changeset/219288>

Comment 5 WebKit Commit Bot 2017-07-10 03:13:52 PDT

All reviewed patches have been landed.  Closing bug.