Bug 174260 – REGRESSION(r219194): [GStreamer] http/tests/media/video-redirect.html is failing

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Charlie Turner]

This was some fallout from r219194. The reason was not omitting an extra place we needed to convert URL's to using our internal protocol schema.
These workarounds can go away once the upstream bug to be able to set ranks per-element get in.

[Charlie Turner]

Created attachment 314861 [details]
Patch

[Carlos Alberto Lopez Perez]

Comment on attachment 314861 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314861&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:229
> -    m_url = URL(URL(), cleanURLString);
> +    URL cleanURL = URL(URL(), cleanURLString);
> +    convertToInternalProtocol(cleanURL);
>  
> -    if (m_url.protocolIsInHTTPFamily())
> -        m_url.setProtocol("webkit+" + url.protocol());
> +    m_url = cleanURL;

Why using an extra variable cleanURL and not simply doing ...

m_url = URL(URL(), cleanURLString);
convertToInternalProtocol(m_url);


??

[Charlie Turner]

Created attachment 314969 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 314969 [details]
Patch

Clearing flags on attachment: 314969

Committed r219288: <http://trac.webkit.org/changeset/219288>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.