Bug 174254

Summary: [GTK] Media test gardening after r219253
Product: WebKit Reporter: Charlie Turner <cturner>
Component: Tools / TestsAssignee: Charlie Turner <cturner>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lforschler, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Charlie Turner
Reported 2017-07-07 07:12:55 PDT
Patch to follow...
Attachments
Patch (3.71 KB, patch)
2017-07-07 13:23 PDT, Charlie Turner 		no flags
DetailsFormatted DiffDiff
Patch (2.67 KB, patch)
2017-07-12 02:04 PDT, Charlie Turner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Charlie Turner
Comment 1 2017-07-07 13:23:56 PDT
Created attachment 314870 [details] Patch
Michael Catanzaro
Comment 2 2017-07-11 15:15:59 PDT
Comment on attachment 314870 [details] Patch It'd be advisable to use the WebKitGTK+ or WPE components instead of Tools/Tests, or CC bugs-noreply@webkitgtk.org, so that we see it in a timely manner! I only check for other patches about once a month or so... just happened to do that now.
Michael Catanzaro
Comment 3 2017-07-11 15:20:21 PDT
Comment on attachment 314870 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314870&action=review > LayoutTests/platform/gtk/TestExpectations:154 > +media/video-does-not-loop.html [ WontFix Timeout Crash ] Hm, I'm concerned about this one. In many cases, it's totally expected that a test can never pass on or platform, or expected that the test will hang forever due to use of unsupported JavaScript. But it should never crash. We should never have crash expectations without a bug, because crashes are never acceptable behavior. I see there are a couple other tests with crash expectations but no bugs right below this. That's not good. If you have time, it would be great to file bug reports and add the bugs to the test expectations. > LayoutTests/platform/gtk/TestExpectations:-3228 > -webkit.org/b/163530 media/video-restricted-no-preload-metadata.html [ Failure ] So we should close bug #163530 now, right? It is the only test marked against this bug.
Michael Catanzaro
Comment 4 2017-07-11 15:21:09 PDT
I reset my commit-queue so you can edit this before landing.
Charlie Turner
Comment 5 2017-07-12 02:04:37 PDT
Created attachment 315216 [details] Patch I will leave the crash expectation off because I won't have time to update the expectations for a while, I also noticed video-fast-seek started crashing again, so I'm going to leave it as well. I will close #163530 once this lands
Charlie Turner
Comment 6 2017-07-12 02:05:25 PDT
(Ah, I see you closed it already, thanks :))
Michael Catanzaro
Comment 7 2017-07-12 08:15:03 PDT
Comment on attachment 315216 [details] Patch OK!
WebKit Commit Bot
Comment 8 2017-07-12 09:14:35 PDT
Comment on attachment 315216 [details] Patch Clearing flags on attachment: 315216 Committed r219399: <http://trac.webkit.org/changeset/219399>
WebKit Commit Bot
Comment 9 2017-07-12 09:14:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.