Drop unnecessary uses of targetStatistics.dataRecordsRemoved in ResourceLoadObserver

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Chris Dumez]

Drop unnecessary uses of targetStatistics.dataRecordsRemoved in ResourceLoadObserver. It is always 0 since this member is only initialized later on, in the UIProcess.

[Chris Dumez]

Created attachment 314800 [details]
Patch

[Brent Fulgham]

Comment on attachment 314800 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314800&action=review

Much tidier. Thank you for cleaning this up!

> Source/WebCore/loader/ResourceLoadObserver.cpp:146
>      {

Do we need this scope? I think it might have been here to support locking, which we don't do anymore.

[Chris Dumez]

Comment on attachment 314800 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314800&action=review

>> Source/WebCore/loader/ResourceLoadObserver.cpp:146
>>      {
> 
> Do we need this scope? I think it might have been here to support locking, which we don't do anymore.

I added it to make sure people do not use targetStatistics later on in this function since the reference gets invalidated by the later call to ensureResourceStatisticsForPrimaryDomain() in this function.

[WebKit Commit Bot]

Comment on attachment 314800 [details]
Patch

Clearing flags on attachment: 314800

Committed r219236: <http://trac.webkit.org/changeset/219236>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.