Bug 174231

Summary:

Add extra insurance to prevent clang from making crash traces sad

Product:

WebKit

Reporter:

Keith Miller <keith_miller>

Component:

New Bugs

Assignee:

Keith Miller <keith_miller>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, buildbot, cdumez, cmarcelo, commit-queue, dbates, saam, ysuzuki

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch for landing	none
Patch	none

Keith Miller

Reported 2017-07-06 18:11:37 PDT

Add extra insurance to prevent clang from making crash traces sad

Attachments
Patch (4.71 KB, patch) 2017-07-06 18:18 PDT, Keith Miller	no flags	Details Formatted Diff Diff
Patch for landing (4.70 KB, patch) 2017-07-06 18:37 PDT, Keith Miller	no flags	Details Formatted Diff Diff
Patch for landing (4.74 KB, patch) 2017-07-06 19:59 PDT, Keith Miller	no flags	Details Formatted Diff Diff
Patch (1.03 KB, patch) 2017-07-07 00:30 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Keith Miller

Comment 1 2017-07-06 18:18:07 PDT

Created attachment 314782 [details] Patch

Keith Miller

Comment 2 2017-07-06 18:37:37 PDT

Created attachment 314783 [details] Patch for landing

WebKit Commit Bot

Comment 3 2017-07-06 19:05:49 PDT

Comment on attachment 314783 [details] Patch for landing Rejecting attachment 314783 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ed. ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WTF.build/Release/WTF.build/Objects-normal/x86_64/CollatorDefault.o wtf/unicode/CollatorDefault.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WTF.build/Release/WTF.build/Objects-normal/x86_64/CryptographicUtilities.o wtf/CryptographicUtilities.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (2 failures) Full output: http://webkit-queues.webkit.org/results/4066555

Keith Miller

Comment 4 2017-07-06 19:59:57 PDT

Created attachment 314795 [details] Patch for landing

WebKit Commit Bot

Comment 5 2017-07-06 20:35:30 PDT

Comment on attachment 314795 [details] Patch for landing Clearing flags on attachment: 314795 Committed r219233: <http://trac.webkit.org/changeset/219233>

WebKit Commit Bot

Comment 6 2017-07-06 20:35:31 PDT

All reviewed patches have been landed. Closing bug.

Yusuke Suzuki

Comment 7 2017-07-06 22:33:46 PDT

Committed r219244: <http://trac.webkit.org/changeset/219244>