Bug 174231

Summary: Add extra insurance to prevent clang from making crash traces sad
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, cdumez, cmarcelo, commit-queue, dbates, saam, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing
none
Patch none

Description Keith Miller 2017-07-06 18:11:37 PDT 
Add extra insurance to prevent clang from making crash traces sad
Comment 1 Keith Miller 2017-07-06 18:18:07 PDT 
Created attachment 314782 [details]
Patch
Comment 2 Keith Miller 2017-07-06 18:37:37 PDT 
Created attachment 314783 [details]
Patch for landing
Comment 3 WebKit Commit Bot 2017-07-06 19:05:49 PDT 
Comment on attachment 314783 [details]
Patch for landing

Rejecting attachment 314783 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ed.

** BUILD FAILED **


The following build commands failed:
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WTF.build/Release/WTF.build/Objects-normal/x86_64/CollatorDefault.o wtf/unicode/CollatorDefault.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WTF.build/Release/WTF.build/Objects-normal/x86_64/CryptographicUtilities.o wtf/CryptographicUtilities.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(2 failures)

Full output: http://webkit-queues.webkit.org/results/4066555
Comment 4 Keith Miller 2017-07-06 19:59:57 PDT 
Created attachment 314795 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2017-07-06 20:35:30 PDT 
Comment on attachment 314795 [details]
Patch for landing

Clearing flags on attachment: 314795

Committed r219233: <http://trac.webkit.org/changeset/219233>
Comment 6 WebKit Commit Bot 2017-07-06 20:35:31 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Yusuke Suzuki 2017-07-06 22:33:46 PDT 
Committed r219244: <http://trac.webkit.org/changeset/219244>
Comment 8 Yusuke Suzuki 2017-07-06 23:04:10 PDT 
Committed r219247: <http://trac.webkit.org/changeset/219247>
Comment 9 Yusuke Suzuki 2017-07-06 23:08:08 PDT 
Committed r219248: <http://trac.webkit.org/changeset/219248>
Comment 10 Yusuke Suzuki 2017-07-07 00:30:06 PDT 
Reopening to attach new patch.
Comment 11 Yusuke Suzuki 2017-07-07 00:30:08 PDT 
Created attachment 314821 [details]
Patch
Comment 12 Yusuke Suzuki 2017-07-07 01:30:19 PDT 
Committed r219250: <http://trac.webkit.org/changeset/219250>