Bug 174228

Summary: [Cocoa] CTParagraphStyle leak under WebCore::LinkImageLayout::LinkImageLayout
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebCore Misc.Assignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, joepeck, kling, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2017-07-06 16:28:25 PDT
Summary: Checking for leaks I came across a CTParagraphStyle Leak: Leak: 0x6180002dbc10 size=112 zone: DefaultMallocZone_0x10a316000 CTParagraphStyle CFType CoreText Call stack: [thread 0x7fff5a805340]: | start | main | NSApplicationMain | -[NSApplication run] | -[NSApplication(NSEvent) sendEvent:] | -[NSWindow(NSEventRouting) sendEvent:] | -[NSWindow(NSEventRouting) _reallySendEvent:isDelayedEvent:] | -[WebHTMLView mouseDragged:] | WebCore::EventHandler::mouseDragged(NSEvent*, NSEvent*) | WebCore::EventHandler::handleMouseMoveEvent(WebCore::PlatformMouseEvent const&, WebCore::HitTestResult*, bool) | WebCore::EventHandler::handleMouseDraggedEvent(WebCore::MouseEventWithHitTestResults const&, WebCore::CheckDragHysteresis) | WebCore::EventHandler::handleDrag(WebCore::MouseEventWithHitTestResults const&, WebCore::CheckDragHysteresis) | WebCore::DragController::startDrag(WebCore::Frame&, WebCore::DragState const&, WebCore::DragOperation, WebCore::PlatformMouseEvent const&, WebCore::IntPoint const&) | WebCore::createDragImageForLink(WebCore::Element&, WebCore::URL&, WTF::String const&, WebCore::TextIndicatorData&, WebCore::FontRenderingMode, float) | WebCore::LinkImageLayout::LinkImageLayout(WebCore::URL&, WTF::String const&) | WebCore::LinkImageLayout::LinkImageLayout(WebCore::URL&, WTF::String const&)::$_0::operator()(NSString*, NSColor*, NSFont*, long, CTLineBreakMode) const | CTParagraphStyleCreate | _CFRuntimeCreateInstance Should be adopting the Create into a RetainPtr: RetainPtr<CTParagraphStyleRef> paragraphStyle = CTParagraphStyleCreate(paragraphStyleSettings, 1);
Attachments
[PATCH] Proposed Fix (1.43 KB, patch)
2017-07-06 16:30 PDT, Joseph Pecoraro
no flags
Joseph Pecoraro
Comment 1 2017-07-06 16:30:48 PDT
Created attachment 314775 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 2 2017-07-06 17:00:33 PDT
Comment on attachment 314775 [details] [PATCH] Proposed Fix Clearing flags on attachment: 314775 Committed r219226: <http://trac.webkit.org/changeset/219226>
WebKit Commit Bot
Comment 3 2017-07-06 17:00:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.