Summary: | [GTK][WPE] kill-old-process should kill more webkit related process | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||
Component: | Tools / Tests | Assignee: | Carlos Alberto Lopez Perez <clopez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bugs-noreply, lforschler, mcatanzaro | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Carlos Alberto Lopez Perez
2017-07-06 15:13:28 PDT
Created attachment 314763 [details]
Patch
Comment on attachment 314763 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314763&action=review > Tools/BuildSlaveSupport/kill-old-processes:28 > +def listAllWebKitPrograms(build_dir_bin): Nit: I might have named this builddir_bin instead. > Tools/BuildSlaveSupport/kill-old-processes:32 > + if os.access(os.path.join(root, file), os.X_OK): Why do you need to call access? > Tools/BuildSlaveSupport/kill-old-processes:136 > + build_dir_bin = "WebKitBuild/Release/bin" if os.path.isdir("WebKitBuild/Release/bin") else "WebKitBuild/Debug/bin" I was going to object to this, but I guess it would be pretty odd if the built binaries ever differ between release and debug builds, so this seems fine. (In reply to Michael Catanzaro from comment #2) > Comment on attachment 314763 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=314763&action=review > > > Tools/BuildSlaveSupport/kill-old-processes:28 > > +def listAllWebKitPrograms(build_dir_bin): > > Nit: I might have named this builddir_bin instead. > Looks better, will change it. > > Tools/BuildSlaveSupport/kill-old-processes:32 > > + if os.access(os.path.join(root, file), os.X_OK): > > Why do you need to call access? > To check if the file is executable, otherwise I don't want to add its filename to the list of possible webkit-related process. > > Tools/BuildSlaveSupport/kill-old-processes:136 > > + build_dir_bin = "WebKitBuild/Release/bin" if os.path.isdir("WebKitBuild/Release/bin") else "WebKitBuild/Debug/bin" > > I was going to object to this, but I guess it would be pretty odd if the > built binaries ever differ between release and debug builds, so this seems > fine. The idea is to get WebKitBuild/Release/bin on release bots and WebKitBuild/Debug/bin on debug bots. All linux ports (GTK+, WPE and JSCOnly) use one of the two possibilities to store the binaries that will be executed (depending if its a release or a debug bot). Committed r219227: <http://trac.webkit.org/changeset/219227> |