Bug 174196

Summary:

Write a support script to enable buildbot to upload to S3

Product:

WebKit

Reporter:

Lucas Forschler <lforschler>

Component:

Tools / Tests

Assignee:

Lucas Forschler <lforschler>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, lforschler, slewis, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
v1 patch for review	lforschler: commit-queue-
v2 patch for review	lforschler: commit-queue-
v3 patch for review	lforschler: commit-queue+
v4, fixed argparser from feedback	slewis: review+, lforschler: commit-queue-
patch for landing	none

Lucas Forschler

Reported 2017-07-05 22:00:39 PDT

We'd like to use Amazon S3 storage for build artifacts. Teach it.

Attachments
v1 patch for review (2.47 KB, patch) 2017-07-05 22:10 PDT, Lucas Forschler	lforschler: commit-queue-	Details Formatted Diff Diff
v2 patch for review (2.48 KB, patch) 2017-07-06 01:18 PDT, Lucas Forschler	lforschler: commit-queue-	Details Formatted Diff Diff
v3 patch for review (1.90 KB, patch) 2017-07-06 15:07 PDT, Lucas Forschler	lforschler: commit-queue+	Details Formatted Diff Diff
v4, fixed argparser from feedback (1.95 KB, patch) 2017-07-06 20:12 PDT, Lucas Forschler	slewis: review+ lforschler: commit-queue-	Details Formatted Diff Diff
patch for landing (2.66 KB, patch) 2017-07-06 20:27 PDT, Lucas Forschler	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Lucas Forschler

Comment 1 2017-07-05 22:00:56 PDT

<rdar://problem/32653786>

Radar WebKit Bug Importer

Comment 2 2017-07-05 22:02:08 PDT

<rdar://problem/33150682>

Lucas Forschler

Comment 3 2017-07-05 22:10:28 PDT

Created attachment 314696 [details] v1 patch for review

Lucas Forschler

Comment 4 2017-07-06 01:18:24 PDT

Created attachment 314707 [details] v2 patch for review

Lucas Forschler

Comment 5 2017-07-06 15:07:01 PDT

Created attachment 314761 [details] v3 patch for review

Stephanie Lewis

Comment 6 2017-07-06 18:22:27 PDT

Comment on attachment 314761 [details] v3 patch for review View in context: https://bugs.webkit.org/attachment.cgi?id=314761&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3:34 > +args = parser.parse_args() Maybe add help messages. It's not clear without reading the code that the archive arguments is not the path to the minified archive. It might be more natural to allow both. > Tools/BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3:41 > +minifiedArchive = head + '/minified-' + tail Wouldnt this fail if --archive wasn't passed? Why is --archive optional?

Lucas Forschler

Comment 7 2017-07-06 20:12:11 PDT

Created attachment 314799 [details] v4, fixed argparser from feedback

Stephanie Lewis

Comment 8 2017-07-06 20:15:50 PDT

Comment on attachment 314799 [details] v4, fixed argparser from feedback View in context: https://bugs.webkit.org/attachment.cgi?id=314799&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3:16 > + s3.upload_file(archive_path, bucket, key) I don't like using globals in functions. Is there a reason to declare s3 as a global? > Tools/BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3:34 > +head, tail = os.path.split(str(args.archive)) Should probably check if args.archive has a value before calling split on it

Lucas Forschler

Comment 9 2017-07-06 20:21:53 PDT

Comment on attachment 314799 [details] v4, fixed argparser from feedback View in context: https://bugs.webkit.org/attachment.cgi?id=314799&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3:16 >> + s3.upload_file(archive_path, bucket, key) > > I don't like using globals in functions. Is there a reason to declare s3 as a global? would you rather instantiate each time we run through the loop? >> Tools/BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3:34 >> +head, tail = os.path.split(str(args.archive)) > > Should probably check if args.archive has a value before calling split on it the argparser will fail if there is no value

Lucas Forschler

Comment 10 2017-07-06 20:27:43 PDT

Created attachment 314802 [details] patch for landing

WebKit Commit Bot

Comment 11 2017-07-06 22:57:37 PDT

Comment on attachment 314802 [details] patch for landing Clearing flags on attachment: 314802 Committed r219246: <http://trac.webkit.org/changeset/219246>

WebKit Commit Bot

Comment 12 2017-07-06 22:57:38 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.