Bug 174194

Summary: Move ResourceLoadObserver notification throttling logic from WebProcess class to ResourceLoadObserver
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, dbates, ggaren, japhet, wilander
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 174120    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2017-07-05 21:17:50 PDT
Move ResourceLoadObserver notification throttling logic from WebProcess class to ResourceLoadObserver.
Attachments
Patch (10.24 KB, patch)
2017-07-05 21:19 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (10.43 KB, patch)
2017-07-06 09:09 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (10.71 KB, patch)
2017-07-06 10:24 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-07-05 21:19:49 PDT
Created attachment 314694 [details] Patch
Build Bot
Comment 2 2017-07-05 21:22:05 PDT
Attachment 314694 [details] did not pass style-queue: ERROR: Source/WebCore/loader/ResourceLoadObserver.cpp:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/loader/ResourceLoadObserver.h:60: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/loader/ResourceLoadObserver.h:75: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 3 2017-07-06 09:09:11 PDT
Created attachment 314724 [details] Patch
Build Bot
Comment 4 2017-07-06 09:13:02 PDT
Attachment 314724 [details] did not pass style-queue: ERROR: Source/WebCore/loader/ResourceLoadObserver.cpp:57: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/loader/ResourceLoadObserver.h:61: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/loader/ResourceLoadObserver.h:76: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brent Fulgham
Comment 5 2017-07-06 09:50:17 PDT
Comment on attachment 314724 [details] Patch r=me
Chris Dumez
Comment 6 2017-07-06 10:24:19 PDT
Created attachment 314733 [details] Patch
Build Bot
Comment 7 2017-07-06 10:26:10 PDT
Attachment 314733 [details] did not pass style-queue: ERROR: Source/WebCore/loader/ResourceLoadObserver.cpp:57: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/loader/ResourceLoadObserver.h:61: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/loader/ResourceLoadObserver.h:76: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 8 2017-07-06 11:28:44 PDT
Comment on attachment 314733 [details] Patch Clearing flags on attachment: 314733 Committed r219207: <http://trac.webkit.org/changeset/219207>
Chris Dumez
Comment 9 2017-07-06 11:28:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.