Bug 174175

Summary:

Make WebKit's public headers on Mac and iOS C++ module safe

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

WebKit Misc.

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, beidson, ggaren, mitz

Priority:

Version:

Safari Technology Preview

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fixes the header files	achristensen: review+

Ryosuke Niwa

Reported 2017-07-05 14:16:58 PDT

Make our public headers module safe.

Attachments
Fixes the header files (4.65 KB, patch) 2017-07-05 15:16 PDT, Ryosuke Niwa	achristensen: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2017-07-05 15:16:14 PDT

Created attachment 314658 [details] Fixes the header files

Alex Christensen

Comment 2 2017-07-05 15:18:53 PDT

Comment on attachment 314658 [details] Fixes the header files View in context: https://bugs.webkit.org/attachment.cgi?id=314658&action=review r=me with this change. > Source/WebKit2/UIProcess/API/Cocoa/WKContentRuleList.h:27 > +#import <objc/NSObject.h> Should this be Foundation/NSObject.h? > Source/WebKit2/UIProcess/API/Cocoa/WKContentRuleListStore.h:27 > +#import <objc/NSObject.h> ditto

mitz

Comment 3 2017-07-05 15:46:31 PDT

Comment on attachment 314658 [details] Fixes the header files View in context: https://bugs.webkit.org/attachment.cgi?id=314658&action=review >> Source/WebKit2/UIProcess/API/Cocoa/WKContentRuleList.h:27 >> +#import <objc/NSObject.h> > > Should this be Foundation/NSObject.h? Everywhere else in the modern API we import the Foundation umbrella header, and we do so after the #if WK_API_ENABLED test. Is there a reason to do things differently here? >> Source/WebKit2/UIProcess/API/Cocoa/WKContentRuleListStore.h:27 >> +#import <objc/NSObject.h> > > ditto Same here.

Ryosuke Niwa

Comment 4 2017-07-05 16:31:57 PDT

(In reply to mitz from comment #3) > Comment on attachment 314658 [details] > Fixes the header files > > View in context: > https://bugs.webkit.org/attachment.cgi?id=314658&action=review > > >> Source/WebKit2/UIProcess/API/Cocoa/WKContentRuleList.h:27 > >> +#import <objc/NSObject.h> > > > > Should this be Foundation/NSObject.h? > > Everywhere else in the modern API we import the Foundation umbrella header, > and we do so after the #if WK_API_ENABLED test. Is there a reason to do > things differently here? > > >> Source/WebKit2/UIProcess/API/Cocoa/WKContentRuleListStore.h:27 > >> +#import <objc/NSObject.h> > > > > ditto > > Same here. Fixed to include Foundation/Foundation.h inside WK_API_ENABLED instead.

Ryosuke Niwa

Comment 5 2017-07-05 16:40:28 PDT

Committed r219165: <http://trac.webkit.org/changeset/219165>

Note You need to log in before you can comment on or make changes to this bug.