Bug 174145 – We resolve one extra element's style when calling getComputedStyle on a display: none subtree, I think

• Component: CSS
• Status: RESOLVED FIXED

[Emilio Cobos Álvarez]

Noticed this while trying to construct a test-case for bug 172753.

In Element::resolveComputedStyle:

        elementsRequiringComputedStyle.prepend(&ancestor);
        if (auto* existingStyle = ancestor.existingComputedStyle()) {
            computedStyle = existingStyle;
            break;
        }

I think that we resolve style when not needed for that ancestor we find an existing computed style for...

Also, I think, that we resolve the first element inheriting from itself, which seems wrong (though I don't think it's observable, fwiw)... Will post a patch here to run through CI, and will update for review when needed.

[Emilio Cobos Álvarez]

Created attachment 314594 [details]
Patch

[Antti Koivisto]

Nice find, r=me

[WebKit Commit Bot]

Comment on attachment 314594 [details]
Patch

Clearing flags on attachment: 314594

Committed r219138: <http://trac.webkit.org/changeset/219138>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.