Bug 174143

Summary: Crash in UIKit: +[UIViewController _viewControllerForFullScreenPresentationFromView:]
Product: WebKit Reporter: Ada Chan <adachan>
Component: WebKit2Assignee: Ada Chan <adachan>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bdakin, commit-queue, ddkilzer, thorton, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ada Chan
Reported 2017-07-04 17:12:27 PDT
<rdar://problem/28384582> The crash happens in WKActionSheet.mm: - (void)willRotate { ..... UIView *view = [_sheetDelegate hostViewForSheet]; UIViewController *presentingViewController = [UIViewController _viewControllerForFullScreenPresentationFromView:view]; ... } We cannot guarantee that the action sheet belongs in a window, and view could be nil. Passing nil to -[UIViewController _viewControllerForFullScreenPresentationFromView:] causes an exception to be thrown.
Attachments
Patch (2.43 KB, patch)
2017-07-04 17:39 PDT, Ada Chan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ada Chan
Comment 1 2017-07-04 17:39:55 PDT
Created attachment 314588 [details] Patch
Wenson Hsieh
Comment 2 2017-07-04 19:49:52 PDT
Comment on attachment 314588 [details] Patch r=me, this check and the explanation seem reasonable, though I think we still need a wk2r+. I don't know any simple way to test this, but we could make a TestWebKitAPI test case that simulates this situation by broadcasting UIWindowWillRotateNotification after presenting a popover in a WKWebView that's been removed from its UIWindow.
Beth Dakin
Comment 3 2017-07-05 10:16:39 PDT
Comment on attachment 314588 [details] Patch wk2r=me!
WebKit Commit Bot
Comment 4 2017-07-05 10:44:03 PDT
Comment on attachment 314588 [details] Patch Clearing flags on attachment: 314588 Committed r219136: <http://trac.webkit.org/changeset/219136>
WebKit Commit Bot
Comment 5 2017-07-05 10:44:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.