Bug 174080

Summary: Drop ResourceLoadStatisticsStore's statisticsLock
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, wilander
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch bfulgham: review+

Chris Dumez
Reported 2017-07-02 17:31:59 PDT
Drop ResourceLoadStatisticsStore's statisticsLock.
Attachments
Patch (34.33 KB, patch)
2017-07-02 17:42 PDT, Chris Dumez 		bfulgham: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-07-02 17:42:06 PDT
Created attachment 314431 [details] Patch
Build Bot
Comment 2 2017-07-02 17:43:38 PDT
Attachment 314431 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.cpp:534: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.cpp:561: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.cpp:598: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.h:80: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.h:82: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.h:85: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 6 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brent Fulgham
Comment 3 2017-07-03 08:53:34 PDT
Comment on attachment 314431 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314431&action=review Excellent! r=me > Source/WebKit2/ChangeLog:11 > + from the same backbround thread. As a result, there is no longer any need for locking. background -> background
Brent Fulgham
Comment 4 2017-07-03 09:02:47 PDT
Committed r219071: <http://trac.webkit.org/changeset/219071>
Note You need to log in before you can comment on or make changes to this bug.