Bug 174020

Summary: [EME] Solve a couple of compiler warnings
Product: WebKit Reporter: Xabier Rodríguez Calvar <calvaris>
Component: New BugsAssignee: Xabier Rodríguez Calvar <calvaris>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mcatanzaro, zan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Xabier Rodríguez Calvar
Reported 2017-06-30 02:10:12 PDT
[EME] Solve a couple of compiler warnings
Attachments
Patch (2.39 KB, patch)
2017-06-30 02:13 PDT, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.38 KB, patch)
2017-07-03 04:48 PDT, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xabier Rodríguez Calvar
Comment 1 2017-06-30 02:13:03 PDT
Created attachment 314253 [details] Patch
Michael Catanzaro
Comment 2 2017-07-02 09:23:09 PDT
Comment on attachment 314253 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=314253&action=review > Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp:636 > break; Remove this unreachable break
Xabier Rodríguez Calvar
Comment 3 2017-07-03 04:48:42 PDT
Created attachment 314473 [details] Patch for landing
WebKit Commit Bot
Comment 4 2017-07-03 05:36:03 PDT
The commit-queue encountered the following flaky tests while processing attachment 314473 [details]: workers/bomb.html bug 171985 (author: fpizlo@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2017-07-03 05:36:04 PDT
The commit-queue encountered the following flaky tests while processing attachment 314473 [details]: The commit-queue is continuing to process your patch.
Xabier Rodríguez Calvar
Comment 6 2017-07-03 07:33:49 PDT
(In reply to WebKit Commit Bot from comment #5) > The commit-queue is continuing to process your patch. The errors seems unrelated, I'll try to land tomorrow.
WebKit Commit Bot
Comment 7 2017-07-04 04:12:30 PDT
Comment on attachment 314473 [details] Patch for landing Clearing flags on attachment: 314473 Committed r219116: <http://trac.webkit.org/changeset/219116>
WebKit Commit Bot
Comment 8 2017-07-04 04:12:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.