Bug 173992

Summary: Calculating postCapacity in unshiftCountSlowCase is wrong
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Description Saam Barati 2017-06-29 16:32:20 PDT
It'll use more memory than it has allocated.
Comment 1 Saam Barati 2017-06-29 16:33:00 PDT
<rdar://problem/32283199>
Comment 2 Saam Barati 2017-06-29 17:16:48 PDT
Created attachment 314191 [details]
patch
Comment 3 Keith Miller 2017-06-29 17:18:32 PDT
Comment on attachment 314191 [details]
patch

Seems reasonable r=me.
Comment 4 WebKit Commit Bot 2017-06-29 17:58:21 PDT
Comment on attachment 314191 [details]
patch

Clearing flags on attachment: 314191

Committed r218977: <http://trac.webkit.org/changeset/218977>
Comment 5 WebKit Commit Bot 2017-06-29 17:58:22 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Keith Miller 2017-06-30 06:39:14 PDT
It looks like your test is timing out in debug:

https://build.webkit.org/builders/Apple%20Sierra%20Debug%20JSC%20(Tests)/builds/605/steps/jscore-test/logs/stdio
Comment 7 Saam Barati 2017-07-03 11:07:28 PDT
(In reply to Keith Miller from comment #6)
> It looks like your test is timing out in debug:
> 
> https://build.webkit.org/builders/Apple%20Sierra%20Debug%20JSC%20(Tests)/
> builds/605/steps/jscore-test/logs/stdio

I'll disable this test for debug builds.
Comment 8 Saam Barati 2017-07-03 11:23:17 PDT
(In reply to Saam Barati from comment #7)
> (In reply to Keith Miller from comment #6)
> > It looks like your test is timing out in debug:
> > 
> > https://build.webkit.org/builders/Apple%20Sierra%20Debug%20JSC%20(Tests)/
> > builds/605/steps/jscore-test/logs/stdio
> 
> I'll disable this test for debug builds.

https://trac.webkit.org/changeset/219079/webkit