Summary: | Calculating postCapacity in unshiftCountSlowCase is wrong | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Saam Barati <saam> | ||||
Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, ticaiolima, webkit-bug-importer, ysuzuki | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Saam Barati
2017-06-29 16:32:20 PDT
Created attachment 314191 [details]
patch
Comment on attachment 314191 [details]
patch
Seems reasonable r=me.
Comment on attachment 314191 [details] patch Clearing flags on attachment: 314191 Committed r218977: <http://trac.webkit.org/changeset/218977> All reviewed patches have been landed. Closing bug. It looks like your test is timing out in debug: https://build.webkit.org/builders/Apple%20Sierra%20Debug%20JSC%20(Tests)/builds/605/steps/jscore-test/logs/stdio (In reply to Keith Miller from comment #6) > It looks like your test is timing out in debug: > > https://build.webkit.org/builders/Apple%20Sierra%20Debug%20JSC%20(Tests)/ > builds/605/steps/jscore-test/logs/stdio I'll disable this test for debug builds. (In reply to Saam Barati from comment #7) > (In reply to Keith Miller from comment #6) > > It looks like your test is timing out in debug: > > > > https://build.webkit.org/builders/Apple%20Sierra%20Debug%20JSC%20(Tests)/ > > builds/605/steps/jscore-test/logs/stdio > > I'll disable this test for debug builds. https://trac.webkit.org/changeset/219079/webkit |