Bug 173990

Summary: Split ResourceLoadObserver into 2 classes: one for WebCore and one for the UIProcess
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, commit-queue, dbates, ggaren, japhet, wilander
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP Patch
none
Patch
none
Patch
none
Patch none

Description Chris Dumez 2017-06-29 14:18:29 PDT 
Split ResourceLoadObserver into 2 classes: one for WebCore and one for the UIProcess.
Comment 1 Chris Dumez 2017-06-29 14:19:35 PDT 
Created attachment 314165 [details]
WIP Patch
Comment 2 Chris Dumez 2017-06-29 14:43:04 PDT 
Created attachment 314174 [details]
Patch
Comment 3 Chris Dumez 2017-06-29 15:09:50 PDT 
Created attachment 314177 [details]
Patch
Comment 4 Brent Fulgham 2017-06-29 15:49:30 PDT 
Comment on attachment 314177 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314177&action=review

r=me. Once this lands we may be able to get rid of the locks entirely in a follow-up patch.

> Source/WebCore/ChangeLog:9
> +        They really have different API and there is therefore close to no code duplication.

Yes -- maybe they should have significantly different names (in the future).
Comment 5 Chris Dumez 2017-06-29 16:12:43 PDT 
Created attachment 314182 [details]
Patch
Comment 6 Chris Dumez 2017-06-29 16:40:34 PDT 
Comment on attachment 314182 [details]
Patch

Clearing flags on attachment: 314182

Committed r218968: <http://trac.webkit.org/changeset/218968>
Comment 7 Chris Dumez 2017-06-29 16:40:36 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 WebKit Commit Bot 2017-06-29 16:49:27 PDT 
The commit-queue encountered the following flaky tests while processing attachment 314182 [details]:

workers/bomb.html bug 171985 (author: fpizlo@apple.com)
The commit-queue is continuing to process your patch.